Skip to content

fix: replace deprecated codec.ProtoMarshaler interface with proto.Message #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MozirDmitriy
Copy link

@MozirDmitriy MozirDmitriy commented May 10, 2025

Description

  • In testing/utils.go, replaced the parameter type in the UnmarshalMsgResponses function from codec.ProtoMarshaler to proto.Message and added the necessary import
  • In e2e/testsuite/codec.go, also replaced the parameter type in the identically named function

Replacing the deprecated interface helps avoid potential issues in the future when codec.ProtoMarshaler might be completely removed from the codebase. Using the recommended proto.Message interface aligns with SDK development best practices.
The interface replacement maintains the same functionality as the implementation of the functions doesn't use any specific methods of the codec.ProtoMarshaler interface that aren't available in proto.Message.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented May 14, 2025

Sorry for the long wait here! Could you please also add a changelog entry for this under ### Testing API in CHANGELOG.md?

Otherwise, I think this looks good and useful 🙏 Thank you!

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.17%. Comparing base (2032604) to head (f8b1331).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8366   +/-   ##
=======================================
  Coverage   67.17%   67.17%           
=======================================
  Files         280      280           
  Lines       19429    19429           
=======================================
  Hits        13052    13052           
  Misses       5794     5794           
  Partials      583      583           
Flag Coverage Δ
08-wasm 44.28% <ø> (ø)
ibc-go 68.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants