fix: replace deprecated codec.ProtoMarshaler interface with proto.Message #8366
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
testing/utils.go
, replaced the parameter type in theUnmarshalMsgResponses
function fromcodec.ProtoMarshaler
toproto.Message
and added the necessary importe2e/testsuite/codec.go
, also replaced the parameter type in the identically named functionReplacing the deprecated interface helps avoid potential issues in the future when
codec.ProtoMarshaler
might be completely removed from the codebase. Using the recommendedproto.Message
interface aligns with SDK development best practices.The interface replacement maintains the same functionality as the implementation of the functions doesn't use any specific methods of the
codec.ProtoMarshaler
interface that aren't available inproto.Message
.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.