Add configurable max message size enforcement#254
Merged
cosullivan merged 3 commits intocosullivan:masterfrom Aug 3, 2025
Merged
Add configurable max message size enforcement#254cosullivan merged 3 commits intocosullivan:masterfrom
cosullivan merged 3 commits intocosullivan:masterfrom
Conversation
Introduces IMaxMessageSizeOptions, MaxMessageSizeOptions, and MaxMessageSizeHandling to allow configuration of maximum allowed message size and handling strategy. Updates relevant protocol and IO classes to enforce the limit, throwing MaxMessageSizeExceededException when exceeded in strict mode. Adjusts SmtpServerOptionsBuilder and ISmtpServerOptions to use the new options, and adds a test for strict enforcement. Based on this existing pull request of @boba2fett - https://github.com/cosullivan/SmtpServer/pull/213/files#diff-3ef8e28e7d91fa5d1ac55f908d172fc69242455c3a25d0a009c79cadc71916a3
cosullivan
reviewed
Jul 27, 2025
Contributor
Author
|
552 message size exceeds fixed maximium message size
<https://datatracker.ietf.org/doc/html/rfc1653>
[ietf-logo-card.png]
RFC 1653: SMTP Service Extension for Message Size Declaration<https://datatracker.ietf.org/doc/html/rfc1653>
datatracker.ietf.org<https://datatracker.ietf.org/doc/html/rfc1653>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces IMaxMessageSizeOptions, MaxMessageSizeOptions, and MaxMessageSizeHandling to allow configuration of maximum allowed message size and handling strategy. Updates relevant protocol and IO classes to enforce the limit, throwing MaxMessageSizeExceededException when exceeded in strict mode. Adjusts SmtpServerOptionsBuilder and ISmtpServerOptions to use the new options, and adds a test for strict enforcement.
Based on this existing pull request of @boba2fett
Fix the issue
The code should be largely backward compatible since the second parameter was declared as optional in the builder.
An example of the server configuration (Allow max 50 bytes)