Skip to content

c4PeerDiscovery.hh no longer uses nonpublic headers#2301

Merged
borrrden merged 3 commits into
masterfrom
fix/peer-discovery-header
Jul 8, 2025
Merged

c4PeerDiscovery.hh no longer uses nonpublic headers#2301
borrrden merged 3 commits into
masterfrom
fix/peer-discovery-header

Conversation

@snej

@snej snej commented Jul 2, 2025

Copy link
Copy Markdown
Collaborator
  • Split out Observer.hh from ObserverList.hh, and put it in CInclude/. This new header has no special dependencies.
  • Moved fields of C4PeerDiscovery into an Impl class whose declaration is non-public
  • c4PeerDiscovery.hh now includes Observer.hh, not ObserverList.hh.

Implementation changes are in https://github.com/couchbase/couchbase-lite-core-EE/pull/61

@snej snej requested a review from borrrden July 2, 2025 19:28
@cbl-bot

cbl-bot commented Jul 2, 2025

Copy link
Copy Markdown

Code Coverage Results:

Type Percentage
branches 65.93
functions 77.56
instantiations 70.21
lines 77.02
regions 72.92

@borrrden borrrden merged commit 9bf748f into master Jul 8, 2025
8 checks passed
@borrrden borrrden deleted the fix/peer-discovery-header branch July 8, 2025 00:22
jianminzhao added a commit that referenced this pull request Jul 9, 2025
CBL-7156 : Fix iOS cert chain deletion to handle self-signed roots and ensure safe removal (#2303)
CBL-7125: c4Log sometimes does not log anything (#2302)
9bf748f c4PeerDiscovery.hh no longer uses nonpublic headers (#2301)

Included in EE:

CBL-7147: MultipeerReplicator forces its own auth dictionary (#63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants