Skip to content

[DOC-14129]: Magma Compaction rate limiter documentation#4122

Open
RayOffiah wants to merge 6 commits into
release/8.1from
DOC-14129--8.1--Magma-Compaction-rate-limiter-documentation
Open

[DOC-14129]: Magma Compaction rate limiter documentation#4122
RayOffiah wants to merge 6 commits into
release/8.1from
DOC-14129--8.1--Magma-Compaction-rate-limiter-documentation

Conversation

@RayOffiah
Copy link
Copy Markdown
Contributor

Added page detailing REST call for magma compaction.

Update menu navigation and index page.

Signed-off-by: Ray Offiah <ray.offiah@couchbase.com>
@RayOffiah RayOffiah requested a review from ggray-cb May 27, 2026 10:28
@RayOffiah RayOffiah self-assigned this May 27, 2026
@RayOffiah RayOffiah added the enhancement New feature or request label May 27, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds REST API documentation for configuring Magma compaction rate limiting and exposes the page through the REST API navigation and memory/storage API index.

Changes:

  • Added a new Magma Compaction Rate Limiting REST API page with settings, endpoints, and examples.
  • Added the new page to the Memory and Storage API navigation.
  • Added GET/POST endpoint entries to the memory and storage REST API table.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
modules/ROOT/nav.adoc Adds the new REST API page to the Memory and Storage API nav.
modules/rest-api/partials/rest-memory-and-storage-table.adoc Lists the new Magma compaction rate limiting endpoint entries.
modules/rest-api/pages/rest-magma-compaction-rate-limiting.adoc Documents the Magma compaction rate limiting settings and examples.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/rest-api/pages/rest-magma-compaction-rate-limiting.adoc Outdated
Comment thread modules/rest-api/pages/rest-magma-compaction-rate-limiting.adoc Outdated
Comment thread modules/rest-api/pages/rest-magma-compaction-rate-limiting.adoc Outdated
Comment thread modules/rest-api/pages/rest-magma-compaction-rate-limiting.adoc Outdated
Comment thread modules/rest-api/partials/rest-memory-and-storage-table.adoc Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Comment thread modules/rest-api/pages/rest-magma-compaction-rate-limiting.adoc Outdated
Comment thread modules/rest-api/pages/rest-magma-compaction-rate-limiting.adoc Outdated
Comment thread modules/rest-api/pages/rest-magma-compaction-rate-limiting.adoc Outdated
Comment thread modules/rest-api/partials/rest-memory-and-storage-table.adoc Outdated
Comment thread modules/rest-api/partials/rest-memory-and-storage-table.adoc Outdated
Changes made following co-pilot review.

Signed-off-by: Ray Offiah <ray.offiah@couchbase.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread modules/rest-api/pages/rest-magma-compaction-rate-limiting.adoc Outdated
Comment thread modules/rest-api/pages/rest-magma-compaction-rate-limiting.adoc Outdated
RayOffiah and others added 3 commits May 27, 2026 12:34
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Changes made following co-pilot review.

Signed-off-by: Ray Offiah <ray.offiah@couchbase.com>
@RayOffiah RayOffiah requested a review from Copilot May 27, 2026 11:37
Copy link
Copy Markdown
Contributor

@ggray-cb ggray-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have one question/suggestion on adding info about when these limits should be enabled. Otherwise, looks good.

Use these API calls to set the rate limit (in bytes per second).
This setting is a global rate limit for the Memcached process shared across buckets.
The strategy for this rate limiting is to set the block waiting time on the compaction threads to maintain the specified limits.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any guidance we can give for customers as to when they should enable rate limiting? It seems off by default, so I assume they would only enable it if they wre seeing some sort of issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants