Skip to content

ING-1072: Added initial support for XDCR RPCs.#314

Merged
brett19 merged 1 commit into
masterfrom
ING-1072_xdcr_squashed
Nov 12, 2025
Merged

ING-1072: Added initial support for XDCR RPCs.#314
brett19 merged 1 commit into
masterfrom
ING-1072_xdcr_squashed

Conversation

@brett19

@brett19 brett19 commented Nov 10, 2025

Copy link
Copy Markdown
Member

No description provided.

Comment thread gateway/dataimpl/server_v1/xdcrserver.go Fixed
Comment thread gateway/dataimpl/server_v1/xdcrserver.go Fixed
Comment thread gateway/dataimpl/server_v1/xdcrserver.go Fixed
@brett19 brett19 force-pushed the ING-1072_xdcr_squashed branch from 60aec58 to 089fa68 Compare November 10, 2025 22:32

This comment was marked as outdated.

@brett19 brett19 force-pushed the ING-1072_xdcr_squashed branch 2 times, most recently from 803815c to 3b0a359 Compare November 10, 2025 23:00
@brett19 brett19 force-pushed the ING-1072_xdcr_squashed branch from 3b0a359 to 4f54302 Compare November 11, 2025 02:23

@Westwooo Westwooo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just got a few questions

Comment thread docs/XDCR.md
Comment thread docs/XDCR.md
Comment thread gateway/dataimpl/server_v1/errorhandler.go
Comment thread gateway/dataimpl/server_v1/xdcrserver.go
Comment thread gateway/dataimpl/server_v1/xdcrserver.go
Comment thread gateway/dataimpl/server_v1/xdcrserver.go
Comment thread gateway/dataimpl/server_v1/xdcrserver.go

@Westwooo Westwooo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all those answers, looks good to me

@brett19 brett19 merged commit 764b111 into master Nov 12, 2025
18 checks passed
@brett19 brett19 deleted the ING-1072_xdcr_squashed branch November 12, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants