ING-1191: Run and make invalid bucket name tests pass#327
Merged
Conversation
chvck
approved these changes
Dec 11, 2025
Westwooo
force-pushed
the
ING-1191-invalid-bucket-names
branch
from
c8b3cc4 to
c1bab74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs the tests for error cases where the bucket name is blank or contains characters that require url escaping. The expected return code when the bucket name has invalid chars depends on the test, when teh bucket name is used in a url the result is not found. When it is sent as part of the body to the server, in create, we get an invalid argument.