ING-1373: Include resource type in procondition failure subjects#328
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes the format of Subject fields in PreconditionFailure violations by prefixing them with resource types. This improves clarity and consistency in error reporting by making it explicit what kind of resource each subject refers to.
Key Changes:
- Added resource type prefixes ("bucket/", "document/", "queryindex/") to all
Subjectfields in precondition failure violations - Updated the
NewSdValueOutOfRangeStatusfunction signature to accept additional parameters (bucketName, scopeName, collectionName, docId) needed for the new subject format
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chvck
force-pushed
the
ING-1373_prcondition_resource_type
branch
from
ee3787f to
811b335
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
brett19
approved these changes
Dec 11, 2025
chvck
force-pushed
the
ING-1373_prcondition_resource_type
branch
from
811b335 to
d26e972
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.