ING-1431: Implement cluster edition in XDCR GetClusterInfo.#357
Merged
Conversation
chvck
previously approved these changes
Mar 17, 2026
There was a problem hiding this comment.
Pull request overview
Updates the XDCR GetClusterInfo response to include the cluster edition (enterprise vs community), aligning the gateway’s XDCR API with the newer goprotostellar proto definitions.
Changes:
- Bump
github.com/couchbase/goprotostellarto a newer pseudo-version containing the cluster edition field. - Populate
GetClusterInfoResponse.Editionbased onclusterInfo.IsEnterprise. - Extend XDCR integration test to validate the edition field is present.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updates goprotostellar dependency to version that includes cluster edition support. |
| go.sum | Syncs checksums for the updated goprotostellar version. |
| gateway/dataimpl/server_v1/xdcrserver.go | Sets Edition in GetClusterInfo responses based on cluster info. |
| gateway/test/xdcr_test.go | Adds an assertion that Edition is non-nil in XDCR GetClusterInfo test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
brett19
force-pushed
the
ING-1431_cluster-edition
branch
from
6094f97 to
1497467
Compare
chvck
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.