Skip to content

ING-1451: Add support for VBUUID to CheckDocument#363

Merged
chvck merged 1 commit into
masterfrom
ing1451
Apr 13, 2026
Merged

ING-1451: Add support for VBUUID to CheckDocument#363
chvck merged 1 commit into
masterfrom
ing1451

Conversation

@chvck
Copy link
Copy Markdown
Collaborator

@chvck chvck commented Apr 9, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds vBucket UUID (VBUUID) divergence handling to the XDCR CheckDocument RPC so callers can detect vbucket history mismatches and receive a structured VBUUID_MISMATCH error.

Changes:

  • Pass optional VbUuid from CheckDocumentRequest into KV GetMeta via GetMetaOptions.VBUUID and map ErrVbucketUUIDMismatch to an aborted gRPC status with VBUUID_MISMATCH details.
  • Add CheckDocument integration tests covering VBUUID mismatch scenarios.
  • Bump github.com/couchbase/goprotostellar dependency revision.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
gateway/dataimpl/server_v1/xdcrserver.go Threads VbUuid into GetMeta and maps vbuuid mismatch errors to a structured status.
gateway/test/xdcr_test.go Adds CheckDocument tests expecting VBUUID_MISMATCH error details.
go.mod Updates goprotostellar version.
go.sum Updates sums for the goprotostellar version bump.
testutils/config.go Changes default Couchbase connstr (appears unrelated to PR purpose).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gateway/test/xdcr_test.go
Comment thread gateway/test/xdcr_test.go
Comment thread gateway/test/xdcr_test.go
Comment thread gateway/test/xdcr_test.go
Comment thread testutils/config.go
@chvck chvck merged commit 2dc8ad3 into master Apr 13, 2026
26 checks passed
@chvck chvck deleted the ing1451 branch April 13, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants