Conversation
There was a problem hiding this comment.
Pull request overview
Adds vBucket UUID (VBUUID) divergence handling to the XDCR CheckDocument RPC so callers can detect vbucket history mismatches and receive a structured VBUUID_MISMATCH error.
Changes:
- Pass optional
VbUuidfromCheckDocumentRequestinto KVGetMetaviaGetMetaOptions.VBUUIDand mapErrVbucketUUIDMismatchto an aborted gRPC status withVBUUID_MISMATCHdetails. - Add
CheckDocumentintegration tests covering VBUUID mismatch scenarios. - Bump
github.com/couchbase/goprotostellardependency revision.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
gateway/dataimpl/server_v1/xdcrserver.go |
Threads VbUuid into GetMeta and maps vbuuid mismatch errors to a structured status. |
gateway/test/xdcr_test.go |
Adds CheckDocument tests expecting VBUUID_MISMATCH error details. |
go.mod |
Updates goprotostellar version. |
go.sum |
Updates sums for the goprotostellar version bump. |
testutils/config.go |
Changes default Couchbase connstr (appears unrelated to PR purpose). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Westwooo
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.