ING-1464: Added support for reporting mixed cluster editions.#367
Merged
Conversation
chvck
approved these changes
Apr 27, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the XDCR GetClusterInfo response to correctly report “mixed” Couchbase cluster editions, aligning the gateway’s behavior with updated gocbcorex/goprotostellar capabilities.
Changes:
- Bump
github.com/couchbase/gocbcorexandgithub.com/couchbase/goprotostellarto versions that support mixed-edition reporting. - Update XDCR
GetClusterInfoto use aggregated cluster info and map editions to Enterprise / Community / Mixed. - Expand the XDCR integration test to accept the new
CLUSTER_EDITION_MIXEDenum value.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates Couchbase dependency versions needed for aggregated/mixed edition support. |
| go.sum | Locks updated module checksums for the bumped Couchbase dependencies. |
| gateway/dataimpl/server_v1/xdcrserver.go | Switches to aggregated cluster info and adds Mixed edition selection logic. |
| gateway/test/xdcr_test.go | Updates test assertions to allow the new Mixed edition enum. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.