[AV-127654] Add comprehensive acceptance tests for app_endpoint resource by nimiyajoseph · Pull Request #578 · couchbasecloud/terraform-provider-couchbase-capella

nimiyajoseph · 2026-05-04T11:10:04Z

Jira

AV-127654

Description

Acceptance tests — infrastructure (acceptance_tests/)

globals.go

Added named global bucket constants for all fixture endpoints and app_endpoint resource tests, replacing random-named buckets
Each test gets a stable, pre-created bucket — eliminates 500 errors on bucket creation and 412 errors on bucket cleanup

endpoint_setup.go (new file)

ensureFixtureBucketByName — creates a named bucket exactly once per test process using sync.Once, safe for parallel tests
ensure{ACF,IF,CORS,CORSOriginOnly,OIDC,DefaultOIDC}Endpoint — lazily provisions shared sub-resource test endpoints sequentially before parallel tests run

app_endpoint.go

Added bucket parameter to createAppEndpoint so each caller specifies its own bucket (prevents 409 conflicts)
Added retry loop for transient 500 errors on endpoint creation (App Service overloaded during warmup)

setup_test.go

Updated createAppEndpoint call sites to pass bucket name

Acceptance tests — test files

app_endpoint_acceptance_test.go

Full CRUD and update coverage: NoCors, CorsFullConfig, CorsSpecificOrigins, CorsMaxAgeZeroSilentDrift, OIDCFullFields, OIDCDiscoveryURL, UpdateCorsExpand, UpdateCorsOriginWildcardToSpecific, UpdateAddOIDC, UpdateACF, UpdateCorsMaxAgeToZero, UpdateCorsMaxAgeFromZero
Each test calls ensureFixtureBucketByName before resource.ParallelTest; Terraform HCL no longer owns bucket lifecycle
Known-broken cases skipped with Jira references: CorsDisabledFalseNoOrigin (AV-128217), MultipleOIDC (AV-128222), UpdateRemoveCors (AV-128229), UpdateCorsDisableToggle (AV-128229), UpdateRemoveOIDC (AV-128167)
app_endpoint_access_control_function_acceptance_test.go, app_endpoint_import_filter_acceptance_test.go, app_endpoint_cors_acceptance_test.go, app_endpoint_oidc_provider_acceptance_test.go (new files)

Sub-resource tests using pre-created shared endpoints via ensure*Endpoint
app_endpoint_datasource_acceptance_test.go (new file)

Single-endpoint, activation-status, and filtered-list data source tests
Unfiltered list test (TestAccAppEndpointsDataSource) skipped: returns 500 under parallel load (AV-128XXX)

Type of Change

Bug fix (non-breaking change which fixes an issue).
New feature (non-breaking change which adds functionality).
Breaking change (fix or feature that would cause existing functionality to not work as expected).
This change updates the ci/cd workflow.
Documentation fix/enhancement.

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

Manually tested
Unit tested
Acceptance tested
Unable to test / will not test (Please provide comments in section below)

Testing

2026/05/04 15:25:24 Using existing project: 8a4f03e1-0c0b-4a25-b655-261fd5f51eaa
2026/05/04 15:28:27 cluster created
2026/05/04 15:29:29 bucket created
2026/05/04 15:34:32 app service created
2026/05/04 15:35:34 app endpoint state Offline
=== RUN   TestAccAppEndpoint
=== PAUSE TestAccAppEndpoint
=== RUN   TestAccAppEndpointInexistentCollection
--- PASS: TestAccAppEndpointInexistentCollection (4.15s)
=== RUN   TestAccAppEndpointNoCors
--- PASS: TestAccAppEndpointNoCors (309.94s)
=== RUN   TestAccAppEndpointCorsDisabledFalseNoOrigin
--- PASS: TestAccAppEndpointCorsDisabledFalseNoOrigin (3.36s)
=== RUN   TestAccAppEndpointCorsFullConfig
=== PAUSE TestAccAppEndpointCorsFullConfig
=== RUN   TestAccAppEndpointMultipleOIDC
--- PASS: TestAccAppEndpointMultipleOIDC (6.22s)
=== RUN   TestAccAppEndpointCorsSpecificOrigins
=== PAUSE TestAccAppEndpointCorsSpecificOrigins
=== RUN   TestAccAppEndpointCorsMaxAgeZeroSilentDrift
=== PAUSE TestAccAppEndpointCorsMaxAgeZeroSilentDrift
=== RUN   TestAccAppEndpointOIDCFullFields
=== PAUSE TestAccAppEndpointOIDCFullFields
=== RUN   TestAccAppEndpointOIDCDiscoveryURL
=== PAUSE TestAccAppEndpointOIDCDiscoveryURL
=== RUN   TestAccAppEndpointUpdateCorsExpand
=== PAUSE TestAccAppEndpointUpdateCorsExpand
=== RUN   TestAccAppEndpointUpdateRemoveCors
--- PASS: TestAccAppEndpointUpdateRemoveCors (311.07s)
=== RUN   TestAccAppEndpointUpdateCorsDisableToggle
=== PAUSE TestAccAppEndpointUpdateCorsDisableToggle
=== RUN   TestAccAppEndpointUpdateCorsOriginWildcardToSpecific
=== PAUSE TestAccAppEndpointUpdateCorsOriginWildcardToSpecific
=== RUN   TestAccAppEndpointUpdateAddOIDC
=== PAUSE TestAccAppEndpointUpdateAddOIDC
=== RUN   TestAccAppEndpointUpdateRemoveOIDC
=== PAUSE TestAccAppEndpointUpdateRemoveOIDC
=== RUN   TestAccAppEndpointUpdateACF
=== PAUSE TestAccAppEndpointUpdateACF
=== RUN   TestAccAppEndpointUpdateCorsMaxAgeToZero
=== PAUSE TestAccAppEndpointUpdateCorsMaxAgeToZero
=== RUN   TestAccAppEndpointUpdateCorsMaxAgeFromZero
--- PASS: TestAccAppEndpointUpdateCorsMaxAgeFromZero (312.27s)
=== RUN   TestAccAppEndpointAccessControlFunction
--- PASS: TestAccAppEndpointAccessControlFunction (5.09s)
=== RUN   TestAccAppEndpointActivationStatus
=== PAUSE TestAccAppEndpointActivationStatus
=== RUN   TestAccAppEndpointCorsResource
--- PASS: TestAccAppEndpointCorsResource (4.99s)
=== RUN   TestAccAppEndpointCorsResourceOriginOnly
=== PAUSE TestAccAppEndpointCorsResourceOriginOnly
=== RUN   TestAccAppEndpointDataSource
=== PAUSE TestAccAppEndpointDataSource
=== RUN   TestAccAppEndpointActivationStatusDataSource
=== PAUSE TestAccAppEndpointActivationStatusDataSource
=== RUN   TestAccAppEndpointsDataSource
=== PAUSE TestAccAppEndpointsDataSource
=== RUN   TestAccAppEndpointsDataSourceFiltered
--- PASS: TestAccAppEndpointsDataSourceFiltered (1.73s)
=== RUN   TestAccAppEndpointImportFilter
--- PASS: TestAccAppEndpointImportFilter (5.57s)
=== RUN   TestAccAppEndpointOidcProvider
--- PASS: TestAccAppEndpointOidcProvider (5.81s)
=== RUN   TestAccAppEndpointDefaultOidcProvider
--- PASS: TestAccAppEndpointDefaultOidcProvider (4.30s)
=== CONT  TestAccAppEndpoint
=== CONT  TestAccAppEndpointUpdateAddOIDC
=== CONT  TestAccAppEndpointCorsResourceOriginOnly
=== CONT  TestAccAppEndpointUpdateCorsMaxAgeToZero
=== CONT  TestAccAppEndpointUpdateACF
=== CONT  TestAccAppEndpointUpdateRemoveOIDC
=== CONT  TestAccAppEndpointUpdateCorsDisableToggle
=== CONT  TestAccAppEndpointUpdateCorsOriginWildcardToSpecific
=== CONT  TestAccAppEndpointCorsMaxAgeZeroSilentDrift
=== CONT  TestAccAppEndpointCorsSpecificOrigins
=== CONT  TestAccAppEndpointUpdateCorsExpand
=== CONT  TestAccAppEndpointOIDCDiscoveryURL
=== CONT  TestAccAppEndpointCorsFullConfig
=== CONT  TestAccAppEndpointActivationStatus
=== RUN   TestAccAppEndpointActivationStatus/App_Endpoint_Activation_Status
--- PASS: TestAccAppEndpointCorsResourceOriginOnly (32.90s)
=== CONT  TestAccAppEndpointOIDCFullFields
=== RUN   TestAccAppEndpointActivationStatus/App_Endpoint_Resync
--- PASS: TestAccAppEndpointActivationStatus (127.97s)
    --- PASS: TestAccAppEndpointActivationStatus/App_Endpoint_Activation_Status (117.29s)
    --- PASS: TestAccAppEndpointActivationStatus/App_Endpoint_Resync (10.68s)
=== CONT  TestAccAppEndpointActivationStatusDataSource
--- PASS: TestAccAppEndpointActivationStatusDataSource (1.80s)
=== CONT  TestAccAppEndpointsDataSource
--- PASS: TestAccAppEndpointsDataSource (1.74s)
=== CONT  TestAccAppEndpointDataSource
--- PASS: TestAccAppEndpointDataSource (1.81s)
--- PASS: TestAccAppEndpointCorsMaxAgeZeroSilentDrift (337.55s)
--- PASS: TestAccAppEndpointOIDCDiscoveryURL (339.83s)
--- PASS: TestAccAppEndpointCorsSpecificOrigins (340.80s)
--- PASS: TestAccAppEndpointUpdateCorsDisableToggle (341.84s)
--- PASS: TestAccAppEndpointCorsFullConfig (342.08s)
--- PASS: TestAccAppEndpointOIDCFullFields (312.96s)
--- PASS: TestAccAppEndpointUpdateCorsMaxAgeToZero (346.65s)
--- PASS: TestAccAppEndpointUpdateRemoveOIDC (346.86s)
--- PASS: TestAccAppEndpointUpdateCorsExpand (409.39s)
--- PASS: TestAccAppEndpoint (410.37s)
--- PASS: TestAccAppEndpointUpdateAddOIDC (411.35s)
--- PASS: TestAccAppEndpointUpdateCorsOriginWildcardToSpecific (411.35s)
--- PASS: TestAccAppEndpointUpdateACF (411.53s)
PASS
ok  	github.com/couchbasecloud/terraform-provider-couchbase-capella/acceptance_tests	2240.372s

Further comments

github-actions · 2026-05-04T11:10:16Z

No PR template selections were detected. Please make sure to fill out the PR template properly by selecting the appropriate checkboxes.

factory-droid · 2026-05-04T11:10:21Z

Droid finished @nimiyajoseph's task —— View job

Copilot

Pull request overview

Adds broad acceptance test coverage around the couchbase-capella_app_endpoint ecosystem (CORS, OIDC, import, lifecycle edge-cases), alongside provider-side fixes to reduce import drift and improve deletion stability.

Changes:

Extend app_endpoint acceptance coverage with multiple new scenario-focused tests (including import verification via name identifier).
Adjust provider Read behavior to avoid suppressing remote CORS during import.
Add post-DELETE polling for App Endpoint removal to reduce downstream 412/“still in use” failures (notably bucket deletion races).

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
internal/resources/app_endpoint.go	Detect import to avoid CORS suppression; add post-delete polling wait for 404.
acceptance_tests/bucket.go	Whitespace-only change.
acceptance_tests/app_endpoint.go	Prevent nil-body unmarshal panic by retrying on transient GET errors.
acceptance_tests/app_endpoint_acceptance_test.go	Adds many new app_endpoint acceptance scenarios; adjusts some tests to run serially.
acceptance_tests/app_endpoint_datasource_acceptance_test.go	New acceptance tests for app_endpoint-related data sources (single, list, filtered).
acceptance_tests/app_endpoint_cors_acceptance_test.go	New acceptance tests for the app_endpoint_cors resource (CRUD + import).
acceptance_tests/app_endpoint_oidc_provider_acceptance_test.go	New acceptance tests for OIDC provider + default provider resources (CRUD + import).
acceptance_tests/app_endpoint_import_filter_acceptance_test.go	New acceptance tests for app_endpoint_import_filter resource (CRUD + import).
acceptance_tests/app_endpoint_access_control_function_acceptance_test.go	New acceptance tests for app_endpoint_access_control_function resource (CRUD + import).

Comments suppressed due to low confidence (1)

acceptance_tests/app_endpoint_acceptance_test.go:96

This test creates its own bucket/endpoint with randomized names and only validates an expected error; there’s no apparent ordering dependency. Per acceptance test guidelines, prefer resource.ParallelTest here to avoid serializing the suite unnecessarily.

	resource.Test(t, resource.TestCase{
		ProtoV6ProviderFactories: globalProtoV6ProviderFactory,
		Steps: []resource.TestStep{
			{
				Config:      cfg,
				ExpectError: re.MustCompile("Collection Not Found"),
			},
		},

factory-droid

Validated 5 candidates: 3 are actionable and correctly anchored, and 2 were rejected because their anchors are outside changed diff hunks. The approved items cover concrete issues in waitForEndpointDeletion error/cancellation handling and a real acceptance-test flake risk from parallel writes to a shared global endpoint.

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 7 comments.

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 8 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

…er/app service/bucket/endpoint under the existing project

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

stanleefdz

LGTM

* main: [AV-129819] Add build time generator to parse enums from open-api spec (#581) [AV-130261] Fix the ConfigurationType non-pointer field (#588) [AV-127654] Add comprehensive acceptance tests for app_endpoint resource (#578)

AV-127654: Add comprehensive acceptance tests for app_endpoint resource

7b6dc76

Copilot AI review requested due to automatic review settings May 4, 2026 11:10

nimiyajoseph requested a review from a team as a code owner May 4, 2026 11:10

github-actions Bot added the needs-triage label May 4, 2026

Copilot started reviewing on behalf of nimiyajoseph May 4, 2026 11:10 View session

nimiyajoseph marked this pull request as draft May 4, 2026 11:10

Copilot AI reviewed May 4, 2026

View reviewed changes

factory-droid Bot reviewed May 4, 2026

View reviewed changes

Comment thread internal/resources/app_endpoint.go Outdated

factory-droid Bot reviewed May 4, 2026

View reviewed changes

Comment thread internal/resources/app_endpoint.go

factory-droid Bot reviewed May 4, 2026

View reviewed changes

Comment thread acceptance_tests/app_endpoint_cors_acceptance_test.go

factory-droid Bot reviewed May 4, 2026

View reviewed changes

resolve copilot comments

22fd12d

github-actions Bot added the bug Something isn't working label May 4, 2026

nimiyajoseph requested a review from Copilot May 4, 2026 12:11

Copilot started reviewing on behalf of nimiyajoseph May 4, 2026 12:12 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

resolve copilot comments

24f12d5

github-actions Bot added the documentation Improvements or additions to documentation label May 4, 2026

nimiyajoseph requested a review from Copilot May 4, 2026 13:15

Copilot started reviewing on behalf of nimiyajoseph May 4, 2026 13:16 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

Comment thread internal/resources/app_endpoint.go Outdated

Comment thread internal/resources/app_endpoint.go Outdated

Comment thread acceptance_tests/app_endpoint.go Outdated

resolve copilot comments

edd7035

nimiyajoseph requested a review from Copilot May 4, 2026 13:33

Copilot started reviewing on behalf of nimiyajoseph May 4, 2026 13:34 View session

resolve lint error

1869558

Copilot AI reviewed May 4, 2026

View reviewed changes

nimiyajoseph and others added 2 commits May 4, 2026 19:13

Potential fix for pull request finding

04d33aa

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

f2631d1

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of nimiyajoseph May 7, 2026 13:53 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread acceptance_tests/globals.go Outdated

Comment thread acceptance_tests/endpoint_setup.go

Comment thread acceptance_tests/app_endpoint.go Outdated

Comment thread acceptance_tests/app_endpoint.go

Potential fix for pull request finding

015d706

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

nimiyajoseph requested a review from Copilot May 7, 2026 15:11

Copilot started reviewing on behalf of nimiyajoseph May 7, 2026 15:12 View session

nimiyajoseph force-pushed the AV-127654-acceptance-test-for-app-end-points branch from 3d0dcb4 to dfd1361 Compare May 7, 2026 15:13

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread acceptance_tests/setup_test.go

nimiyajoseph force-pushed the AV-127654-acceptance-test-for-app-end-points branch from dfd1361 to 492e36b Compare May 7, 2026 15:23

stabilize app endpoint fixtures and assertions

bd6d54f

nimiyajoseph force-pushed the AV-127654-acceptance-test-for-app-end-points branch from 492e36b to bd6d54f Compare May 7, 2026 16:17

nimiyajoseph added 2 commits May 7, 2026 22:22

Dedicated app endpoint isolation still creates only a dedicated clust…

fa3089e

…er/app service/bucket/endpoint under the existing project

Dedicated app endpoint isolation still creates only a dedicated clust…

6362209

…er/app service/bucket/endpoint under the existing project

nimiyajoseph requested a review from Copilot May 7, 2026 17:20

Copilot started reviewing on behalf of nimiyajoseph May 7, 2026 17:21 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread internal/resources/app_endpoint.go Outdated

Comment thread internal/resources/app_endpoint.go Outdated

Comment thread internal/resources/app_endpoint.go Outdated

Comment thread internal/resources/app_endpoint.go Outdated

addressed that review comment in app_endpoint.go

e8ecc71

nimiyajoseph requested a review from Copilot May 7, 2026 18:30

Copilot started reviewing on behalf of nimiyajoseph May 7, 2026 18:31 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread acceptance_tests/endpoint_setup.go

Comment thread acceptance_tests/endpoint_setup.go

nimiyajoseph requested a review from IsaacLambat May 7, 2026 19:18

addressed that review comment in app_endpoint.go

3785374

nimiyajoseph requested a review from Copilot May 8, 2026 14:34

Copilot started reviewing on behalf of nimiyajoseph May 8, 2026 14:35 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread acceptance_tests/endpoint_setup.go

IsaacLambat approved these changes May 8, 2026

View reviewed changes

stanleefdz approved these changes May 11, 2026

View reviewed changes

nimiyajoseph merged commit 0334801 into main May 11, 2026
20 checks passed

nimiyajoseph deleted the AV-127654-acceptance-test-for-app-end-points branch May 11, 2026 05:33

Conversation

nimiyajoseph commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jira

Description

Type of Change

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

Testing

Further comments

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

factory-droid Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

factory-droid Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

nimiyajoseph commented May 4, 2026 •

edited

Loading

factory-droid Bot commented May 4, 2026 •

edited

Loading