Skip to content

[AV-131530] Implemented short-term graceful degradation fix#611

Merged
nimiyajoseph merged 1 commit into
mainfrom
AV-131530-first-caller-skip-with-full-setup-error
May 22, 2026
Merged

[AV-131530] Implemented short-term graceful degradation fix#611
nimiyajoseph merged 1 commit into
mainfrom
AV-131530-first-caller-skip-with-full-setup-error

Conversation

@nimiyajoseph
Copy link
Copy Markdown
Contributor

@nimiyajoseph nimiyajoseph commented May 21, 2026

Jira

Description

Implemented the short-term graceful degradation fix in [app_endpoint_environment.go:29-42].

What changed: the shared sync.Once setup now tracks whether the current test was the one that actually ran provisioning. If provisioning fails, that first caller is skipped with the full setup error, and every later app-endpoint test skips with a concise “shared setup already failed” message instead of failing instantly with the cached error. That stops the red cascade from ~20 dependent tests.

Type of Change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change updates the ci/cd workflow.
  • Documentation fix/enhancement.

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

  • Manually tested
  • Unit tested
  • Acceptance tested
  • Unable to test / will not test (Please provide comments in section below)

Testing

https://github.com/couchbasecloud/terraform-provider-couchbase-capella/actions/runs/26238064574/job/77218711652?pr=611

=== RUN TestAccAppEndpoint
app_endpoint_acceptance_test.go:13: skipping app endpoint acceptance tests: failed to provision shared test environment: {"code":4025,"hint":"The requested cluster details could not be found or fetched. Please ensure that the correct cluster ID is provided.","httpStatusCode":404,"message":"Unable to fetch the cluster details."}
--- SKIP: TestAccAppEndpoint (241.19s)
=== RUN TestAccAppEndpointInexistentCollection
app_endpoint_acceptance_test.go:54: skipping app endpoint acceptance test: shared test environment provisioning already failed
--- SKIP: TestAccAppEndpointInexistentCollection (0.00s)

Further comments

Copilot AI review requested due to automatic review settings May 21, 2026 16:09
@nimiyajoseph nimiyajoseph requested a review from a team as a code owner May 21, 2026 16:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

🚨 PR title "AV-131530 first caller is skipped with the full setup error" does not match the required format.

Requirements:
- Must start with [AV-XXXXX] where X is any number of digits
- After the bracket, must start with a Verb (Add, Update, Fix, etc.)
- The Verb must start with an uppercase letter

Expected format: [AV-XXXXX] Verb ...
Example: [AV-98659] Implement Cluster On/Off feature
Valid verbs: Add, Update, Fix, Implement, Remove, Refactor, etc.

@github-actions
Copy link
Copy Markdown

No PR template selections were detected. Please make sure to fill out the PR template properly by selecting the appropriate checkboxes.

@nimiyajoseph nimiyajoseph marked this pull request as draft May 21, 2026 16:10
@factory-droid
Copy link
Copy Markdown
Contributor

factory-droid Bot commented May 21, 2026

Droid finished @nimiyajoseph's task —— View job


@nimiyajoseph nimiyajoseph changed the title [AV-131530] first caller is skipped with the full setup error [AV-131530] Implemented the short-term graceful degradation fix May 21, 2026
@nimiyajoseph nimiyajoseph changed the title [AV-131530] Implemented the short-term graceful degradation fix [AV-131530] Implemented short-term graceful degradation fix May 21, 2026
@nimiyajoseph nimiyajoseph self-assigned this May 21, 2026
Copy link
Copy Markdown
Contributor

@factory-droid factory-droid Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated all candidates and found no approved inline findings to post. The diff cleanly implements skip-on-shared-setup-failure behavior for app endpoint acceptance tests without introducing a concrete correctness regression.

@nimiyajoseph nimiyajoseph marked this pull request as ready for review May 21, 2026 17:30
@factory-droid
Copy link
Copy Markdown
Contributor

factory-droid Bot commented May 21, 2026

Droid finished @nimiyajoseph's task —— View job


Comment thread acceptance_tests/app_endpoint_environment.go
Copy link
Copy Markdown
Contributor

@factory-droid factory-droid Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated 1 candidate and approved 1 issue: provisioning setup errors are converted from test failures to skips, which can mask real regressions by allowing green CI on broken setup paths.

Copy link
Copy Markdown
Contributor

@PaulomeeCb PaulomeeCb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nimiyajoseph nimiyajoseph merged commit f36ff9c into main May 22, 2026
24 of 28 checks passed
@nimiyajoseph nimiyajoseph deleted the AV-131530-first-caller-skip-with-full-setup-error branch May 22, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants