[AV-132306] Add app service and endpoint validator acceptance coverage#616
Merged
Talina06 merged 13 commits intoMay 28, 2026
Merged
Conversation
|
No PR template selections were detected. Please make sure to fill out the PR template properly by selecting the appropriate checkboxes. |
Contributor
|
Droid finished @nimiyajoseph's task —— View job |
![factory-droid[bot]](https://avatars.githubusercontent.com/in/358017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
I validated all candidates and approved three actionable issues: two new negative tests can fail before hitting their intended validators due to uninitialized shared app-endpoint IDs, and one new regex is incompatible with stringvalidator.OneOf diagnostic ordering. These are concrete, reproducible test-correctness bugs with valid anchors in the PR diff.
Contributor
|
Droid finished @nimiyajoseph's task —— View job |
nidhi07kumar
previously approved these changes
May 28, 2026
TF_ACC=1 go test -timeout=60m -v ./acceptance_tests/ -run '^TestAccAppServiceLogStreamingDatasourceInvalidUUIDs$' -count=1 Revert "TF_ACC=1 go test -timeout=60m -v ./acceptance_tests/ -run '^TestAccAppServiceLogStreamingDatasourceInvalidUUIDs$' -count=1" This reverts commit b068468.
…on for Azure and GCP (#613)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…er role configuration (#615)
Talina06
force-pushed
the
AV-132306-add-acceptance-coverage-for-app-service-endpoint-validators
branch
from
9832d3d to
1720263
Compare
…ouchbase-capella into AV-132306-add-acceptance-coverage-for-app-service-endpoint-validators
Talina06
approved these changes
May 28, 2026
Talina06
deleted the
AV-132306-add-acceptance-coverage-for-app-service-endpoint-validators
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
Description
Add local Terraform validation coverage for App Endpoint and App Service validator matrix scenarios, including hidden cases where hand-written validators prevented generated OpenAPI enum validators from running.
Total tests added: 9 validation scenarios
New top-level acceptance tests: 8
Additional negative validation steps added/tightened: 2
This PR expands acceptance coverage for App Endpoint and App Service validation behavior and fixes schema wiring so generated OpenAPI validators run where expected.
Changes include:
New top-level acceptance tests:
Additional validation scenarios added/tightened inside existing flows:
What changed:
This should address:
Type of Change
Manual Testing Approach
How was this change tested and do you have evidence? (REQUIRED: Select at least 1)
Testing
Testing
Further comments