Skip to content

[AV-132461] Add private endpoint DNS exposure and acceptance coverage#620

Merged
Talina06 merged 3 commits into
mainfrom
AV-132461-add-acceptance-test-coverage-for-expose-private-endpoint-url-in-terraform-provider
May 28, 2026
Merged

[AV-132461] Add private endpoint DNS exposure and acceptance coverage#620
Talina06 merged 3 commits into
mainfrom
AV-132461-add-acceptance-test-coverage-for-expose-private-endpoint-url-in-terraform-provider

Conversation

@nimiyajoseph
Copy link
Copy Markdown
Contributor

@nimiyajoseph nimiyajoseph commented May 27, 2026 •
edited
Loading

Jira

Description

Expose private_endpoint_dns for Capella private endpoints and add acceptance coverage for the PE-enabled/no-endpoint case.

Changes include:

  • Add acceptance coverage for private endpoint service enabled with no endpoint added.
  • Validate that private_endpoint_dns has the expected hostname shape, including both default Capella domains and custom subdomains.
  • Update generated provider docs for the resource and datasource schema.

Type of Change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change updates the ci/cd workflow.
  • Documentation fix/enhancement.

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

  • Manually tested
  • Unit tested
  • Acceptance tested
  • Unable to test / will not test (Please provide comments in section below)

Testing

Testing

Further comments

Copilot AI review requested due to automatic review settings May 27, 2026 08:36
@nimiyajoseph nimiyajoseph requested a review from a team as a code owner May 27, 2026 08:36
Copilot AI reviewed May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

No PR template selections were detected. Please make sure to fill out the PR template properly by selecting the appropriate checkboxes.

@factory-droid
Copy link
Copy Markdown
Contributor

factory-droid Bot commented May 27, 2026 •
edited
Loading

Droid finished @nimiyajoseph's task —— View job

factory-droid[bot]
factory-droid Bot reviewed May 27, 2026
View reviewed changes
Comment thread acceptance_tests/private_endpoint_acceptance_test.go Outdated
factory-droid[bot]
factory-droid Bot reviewed May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@factory-droid factory-droid Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated 3 candidates and approved 1 high-confidence finding: the new acceptance test asserts private_endpoint_dns, but the provider schema/state/read paths still do not expose or populate that attribute. The remaining two candidates were rejected as docs-only duplicates of the same underlying issue.

@github-actions github-actions Bot added the enhancement New feature or request label May 27, 2026
@factory-droid
Copy link
Copy Markdown
Contributor

factory-droid Bot commented May 27, 2026 •
edited
Loading

Droid finished @nimiyajoseph's task —— View job

@nimiyajoseph nimiyajoseph requested a review from Copilot May 27, 2026 12:22
Copilot AI reviewed May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

factory-droid[bot]
factory-droid Bot reviewed May 27, 2026
View reviewed changes
Comment thread acceptance_tests/private_endpoint_acceptance_test.go Outdated
factory-droid[bot]
factory-droid Bot reviewed May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@factory-droid factory-droid Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated all Phase-1 candidates against the full diff and existing comments. I approved one actionable issue: the new acceptance check data.# == 0 can produce false failures on shared/non-clean clusters. The other two candidates were rejected as non-bug/speculative under the reporting gate.

@nimiyajoseph nimiyajoseph self-assigned this May 27, 2026
@Talina06 Talina06 merged commit 2fa0155 into main May 28, 2026
14 of 15 checks passed
@Talina06 Talina06 deleted the AV-132461-add-acceptance-test-coverage-for-expose-private-endpoint-url-in-terraform-provider branch May 28, 2026 18:56
Talina06 pushed a commit that referenced this pull request May 28, 2026
@nimiyajoseph @Talina06
[AV-132461] Add private endpoint DNS exposure and acceptance coverage (…
e556741 
…#620)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@factory-droid factory-droid[bot] factory-droid[bot] left review comments

Copilot code review Copilot Copilot left review comments

@nidhi07kumar nidhi07kumar nidhi07kumar approved these changes

Assignees

@nimiyajoseph nimiyajoseph

Labels

enhancement New feature or request needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nimiyajoseph @nidhi07kumar @Talina06