Make Couchbase.Core.dll package w/Couchbase.Analytics nuget#47
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Couchbase.Analytics NuGet package configuration to include the Couchbase.Core.dll assembly as part of the package distribution, updating from version 1.0.0-rc1 to 1.0.0-rc3.
- Updated version prefix from 1.0.0-rc1 to 1.0.0-rc3
- Modified project reference configuration to include Couchbase.Core.dll in the Analytics package
- Added MSBuild targets to automatically copy project reference assemblies into the NuGet package
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Couchbase.Analytics/Couchbase.Analytics.csproj | Updated version and configured project reference to include Couchbase.Core.dll in package |
| Directory.Packages.props | Added MSBuild targets to copy project references to NuGet package output |
| tests/Couchbase.Analytics.UnitTests/Couchbase.Analytics.UnitTests.csproj | Added explicit project reference to Couchbase.Core for test compilation |
| fit/Couchbase.Analytics.Performer/Couchbase.Analytics.Performer.csproj | Added explicit project reference to Couchbase.Core for performer compilation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <ProjectReference Include="..\Couchbase.Core\Couchbase.Core.csproj" /> | ||
| <ProjectReference Include="..\Couchbase.Core\Couchbase.Core.csproj" > | ||
| <ReferenceOutputAssembly>true</ReferenceOutputAssembly> | ||
| <IncludeAssets>Couchbase.Core.dll</IncludeAssets> |
There was a problem hiding this comment.
The IncludeAssets element should specify asset types (like 'compile', 'runtime', 'build'), not specific file names. Consider using 'compile;runtime' or 'all' instead of 'Couchbase.Core.dll'.
Suggested change
| <IncludeAssets>Couchbase.Core.dll</IncludeAssets> | |
| <IncludeAssets>compile;runtime</IncludeAssets> |
Closed
emilienbev
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.