Skip to content

Make Couchbase.Core.dll package w/Couchbase.Analytics nuget#47

Merged
jeffrymorris merged 1 commit into
masterfrom
core-pkg
Oct 8, 2025
Merged

Make Couchbase.Core.dll package w/Couchbase.Analytics nuget#47
jeffrymorris merged 1 commit into
masterfrom
core-pkg

Conversation

@jeffrymorris
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the Couchbase.Analytics NuGet package configuration to include the Couchbase.Core.dll assembly as part of the package distribution, updating from version 1.0.0-rc1 to 1.0.0-rc3.

  • Updated version prefix from 1.0.0-rc1 to 1.0.0-rc3
  • Modified project reference configuration to include Couchbase.Core.dll in the Analytics package
  • Added MSBuild targets to automatically copy project reference assemblies into the NuGet package

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/Couchbase.Analytics/Couchbase.Analytics.csproj Updated version and configured project reference to include Couchbase.Core.dll in package
Directory.Packages.props Added MSBuild targets to copy project references to NuGet package output
tests/Couchbase.Analytics.UnitTests/Couchbase.Analytics.UnitTests.csproj Added explicit project reference to Couchbase.Core for test compilation
fit/Couchbase.Analytics.Performer/Couchbase.Analytics.Performer.csproj Added explicit project reference to Couchbase.Core for performer compilation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

<ProjectReference Include="..\Couchbase.Core\Couchbase.Core.csproj" />
<ProjectReference Include="..\Couchbase.Core\Couchbase.Core.csproj" >
<ReferenceOutputAssembly>true</ReferenceOutputAssembly>
<IncludeAssets>Couchbase.Core.dll</IncludeAssets>
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IncludeAssets element should specify asset types (like 'compile', 'runtime', 'build'), not specific file names. Consider using 'compile;runtime' or 'all' instead of 'Couchbase.Core.dll'.

Suggested change
<IncludeAssets>Couchbase.Core.dll</IncludeAssets>
<IncludeAssets>compile;runtime</IncludeAssets>

Copilot uses AI. Check for mistakes.
@jeffrymorris jeffrymorris mentioned this pull request Oct 7, 2025
@jeffrymorris jeffrymorris merged commit f63cd6b into master Oct 8, 2025
3 checks passed
@emilienbev emilienbev deleted the core-pkg branch October 8, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants