Skip to content

NCO-57: Initial implementation of async analytics#52

Merged
davidkelly merged 6 commits into
masterfrom
dk/nco-57
Mar 25, 2026
Merged

NCO-57: Initial implementation of async analytics#52
davidkelly merged 6 commits into
masterfrom
dk/nco-57

Conversation

@davidkelly
Copy link
Copy Markdown
Collaborator

Add async query API:

  • StartQueryAsync, FetchStatusAsync, FetchResultsAsync, DiscardResultsAsync, CancelQueryAsync with QueryHandle, QueryStatus, and StartQueryOptions
  • Add QueryStatus state machine with AreResultsReady, IsError, and GetResults() including defensive handling of undocumented "failed" status observed from server
  • Add comprehensive Debug-level logging across all sync and async methods with request-sent/response-received pairs including URIs, handles, request IDs, and HTTP status codes (events 1–18)
  • Add log redaction framework ported from couchbase-net-client:
  • Redact system data (URIs, handles, request IDs) and user data (query statements) in all log messages; default RedactionLevel.None preserves existing behavior
  • Add ClusterOptions.WithRedactionLevel() for configuring redaction
  • Add unit tests: QueryStatusTests ,RedactionTests

@davidkelly davidkelly marked this pull request as draft March 21, 2026 02:55
@davidkelly davidkelly changed the base branch from master to dk/nco-56 March 21, 2026 03:06
Base automatically changed from dk/nco-56 to master March 21, 2026 20:00
@davidkelly davidkelly marked this pull request as ready for review March 21, 2026 20:00
Copy link
Copy Markdown
Contributor

@jeffrymorris jeffrymorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkelly davidkelly merged commit 6868de0 into master Mar 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants