NCO-58: Flesh out functional testing#60
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds functional coverage for analytics scope-level (query-context) operations and expands async query functional tests, with CI workflow updates to provision the required dataverse for those scope tests.
Changes:
- Add scope-level streaming and blocking query tests for the synchronous API.
- Add scope-level async end-to-end test (start → poll → fetch) plus a cluster-level async metadata/metrics verification test.
- Update CI workflow to wait for analytics readiness and create the required dataverse for scope-level queries.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Couchbase.Analytics.FunctionalTests/Internal/AnalyticsServiceTests.cs | Adds scope-level sync query tests (streaming and blocking). |
| tests/Couchbase.Analytics.FunctionalTests/Fixtures/SimpleFixture.cs | Exposes a TestScope helper for scope-context test calls. |
| tests/Couchbase.Analytics.FunctionalTests/Fixtures/FixtureSettings.cs | Adds configurable database/scope names (with defaults) for scope tests. |
| tests/Couchbase.Analytics.FunctionalTests/AsyncAnalyticsTests.cs | Adds async scope end-to-end test and cluster-level metadata verification. |
| .github/workflows/functional-tests.yml | Waits for analytics readiness and creates the test dataverse needed for scope-level queries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add scope-level streaming and blocking tests for the sync API - Add scope-level end-to-end test for the async API (start→poll→fetch) - Add async metadata verification test at cluster level - Provision bare dataverse in CI workflow for scope-level queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functional tests for sync and async APIs at both cluster and scope level