Skip to content

SDKQE-3597: Use 'default' profile when fetching colima instance data#105

Merged
brett19 merged 1 commit into
couchbaselabs:masterfrom
DemetrisChr:colima-profile-default
May 7, 2025
Merged

SDKQE-3597: Use 'default' profile when fetching colima instance data#105
brett19 merged 1 commit into
couchbaselabs:masterfrom
DemetrisChr:colima-profile-default

Conversation

@DemetrisChr
Copy link
Copy Markdown
Contributor

When cbdino creates dinonet, it attempts to fetch colima instance data with the colima ls command. When more than one profiles exist, the output of colima ls -j looks similar to this:

> colima ls -j
{"name":"default","status":"Running","arch":"aarch64","cpus":4,"memory":6442450944,"disk":107374182400,"address":"192.168.106.2","runtime":"docker+k3s"}
{"name":"second","status":"Running","arch":"aarch64","cpus":2,"memory":2147483648,"disk":64424509440,"runtime":"docker"}

Parsing this output fails (which means creating dinonet also fails) because we assume that the output is a single JSON object.

We can filter the output with the -p default flag to ensure we only get one JSON object for the default profile.

Copy link
Copy Markdown
Contributor

@CosmicSaaurabh CosmicSaaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brett19 brett19 force-pushed the colima-profile-default branch from 730f674 to 93a4ef1 Compare May 7, 2025 16:53
@brett19 brett19 merged commit 465b35a into couchbaselabs:master May 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants