SDKQE-3671: Add failover node commands to docker deployer#139
Merged
Conversation
Contributor
CosmicSaaurabh
left a comment
CosmicSaaurabh
left a comment
There was a problem hiding this comment.
Just a comment, Rest looks good to me!
willbroadbelt
force-pushed
the
addNodeFailoverCmd
branch
from
0590e81 to
3530de2
Compare
brett19
requested changes
Jul 30, 2025
willbroadbelt
force-pushed
the
addNodeFailoverCmd
branch
2 times, most recently
from
9c1893c to
10a5e97
Compare
brett19
previously approved these changes
Aug 1, 2025
Collaborator
brett19
left a comment
brett19
left a comment
There was a problem hiding this comment.
Approved, although a small nit for later that this naming/description could probably be improved:
Use: "failover-recover <cluster-id> <node-id-or-ip>",
Short: "Set recovery mode for a node/s in the cluster",
811b4e1 to
1272009
Compare
New commands: - 'nodes-failover' with hard/graceful options - 'nodes-failover-recover' with recovery type options - 'rebalance' to rebalance cluster with optional nodes to eject
willbroadbelt
force-pushed
the
addNodeFailoverCmd
branch
from
1272009 to
7277c28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New commands: