Skip to content

SDKQE-3817: Support columnar cbcollect log#175

Merged
Aaliya7516 merged 1 commit into
masterfrom
columnar-log
Mar 2, 2026
Merged

SDKQE-3817: Support columnar cbcollect log#175
Aaliya7516 merged 1 commit into
masterfrom
columnar-log

Conversation

@Aaliya7516
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates cloud deployment log collection to work with columnar clusters (cbcollect/server log collection), along with a small CLI message fix and module tidying.

Changes:

  • Enable CollectLogs to start/wait/download logs for both server and columnar clusters in clouddeploy.
  • Fix refresh command fatal log message to match the action performed.
  • Run Go module tidy updates (remove unused indirect deps; make github.com/golang-jwt/jwt/v5 a direct dependency).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
deployment/clouddeploy/deployer.go Add columnar support for log collection; adjust cluster/project identifiers used during operations.
cmd/refresh.go Correct fatal error message text for refresh operation.
go.mod Remove unused indirect dependencies; mark JWT as direct.
go.sum Reflect module tidy changes/removal of unused sums.
Comments suppressed due to low confidence (2)

deployment/clouddeploy/deployer.go:2115

  • Grammar: the log message should use "has" instead of "have" ("Log collection has started...").
		d.logger.Info(fmt.Sprintf("Log collection have started for cluster: %s", cloudClusterId))

deployment/clouddeploy/deployer.go:2114

  • In the error path, errors.Wrap is called but the wrapped error is discarded, so the returned err loses context (and nothing is logged). Assign the wrapped error back to err (or return it directly) so callers get the additional message.
	if err != nil {
		errors.Wrap(err,
			fmt.Sprintf("failed to start server log collection: %s", err))
	} else {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread deployment/clouddeploy/deployer.go
@Aaliya7516 Aaliya7516 merged commit 60ea9fc into master Mar 2, 2026
8 checks passed
@Aaliya7516 Aaliya7516 deleted the columnar-log branch March 2, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants