SDKQE-3817: Support columnar cbcollect log#175
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates cloud deployment log collection to work with columnar clusters (cbcollect/server log collection), along with a small CLI message fix and module tidying.
Changes:
- Enable
CollectLogsto start/wait/download logs for both server and columnar clusters inclouddeploy. - Fix
refreshcommand fatal log message to match the action performed. - Run Go module tidy updates (remove unused indirect deps; make
github.com/golang-jwt/jwt/v5a direct dependency).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
deployment/clouddeploy/deployer.go |
Add columnar support for log collection; adjust cluster/project identifiers used during operations. |
cmd/refresh.go |
Correct fatal error message text for refresh operation. |
go.mod |
Remove unused indirect dependencies; mark JWT as direct. |
go.sum |
Reflect module tidy changes/removal of unused sums. |
Comments suppressed due to low confidence (2)
deployment/clouddeploy/deployer.go:2115
- Grammar: the log message should use "has" instead of "have" ("Log collection has started...").
d.logger.Info(fmt.Sprintf("Log collection have started for cluster: %s", cloudClusterId))
deployment/clouddeploy/deployer.go:2114
- In the error path,
errors.Wrapis called but the wrapped error is discarded, so the returnederrloses context (and nothing is logged). Assign the wrapped error back toerr(or return it directly) so callers get the additional message.
if err != nil {
errors.Wrap(err,
fmt.Sprintf("failed to start server log collection: %s", err))
} else {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willbroadbelt
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.