Skip to content

Better chaos#178

Merged
brett19 merged 3 commits into
masterfrom
better-chaos
Mar 16, 2026
Merged

Better chaos#178
brett19 merged 3 commits into
masterfrom
better-chaos

Conversation

@brett19
Copy link
Copy Markdown
Collaborator

@brett19 brett19 commented Mar 16, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the chaos tooling by adding commands to configure auto-failover and to deterministically select a target node, and wires auto-failover support through the deployment layer (implemented for docker deployments).

Changes:

  • Add SetAutoFailover support to the cluster control controller and to the deployment.Deployer interface (docker implementation + “not supported” stubs elsewhere).
  • Introduce chaos set-auto-failover and chaos pick-node CLI commands.
  • Improve error logging in users add by using structured zap logging instead of fmt.Sprintf.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
utils/clustercontrol/controller.go Adds controller method + options for configuring auto-failover via ns_server settings endpoint.
deployment/deployer.go Extends the Deployer interface with SetAutoFailover.
deployment/dockerdeploy/deployer.go Implements SetAutoFailover for docker-based clusters by calling the controller.
deployment/localdeploy/deployer.go Adds SetAutoFailover stub returning “not supported”.
deployment/clouddeploy/deployer.go Adds SetAutoFailover stub returning “not supported”.
deployment/caodeploy/deployer.go Adds SetAutoFailover stub returning “not supported”.
cmd/users-add.go Switches a fatal error path to structured zap logging; removes unused fmt import.
cmd/chaos-setautofailover.go Adds CLI command to configure cluster auto-failover.
cmd/chaos-pick-node.go Adds CLI command to pick a node (optionally orchestrator) for chaos workflows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread utils/clustercontrol/controller.go
Comment thread utils/clustercontrol/controller.go
Comment thread cmd/chaos-pick-node.go
Comment thread cmd/chaos-setautofailover.go Outdated
@brett19 brett19 merged commit bc9145f into master Mar 16, 2026
4 checks passed
@brett19 brett19 deleted the better-chaos branch March 16, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants