Better chaos#178
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the chaos tooling by adding commands to configure auto-failover and to deterministically select a target node, and wires auto-failover support through the deployment layer (implemented for docker deployments).
Changes:
- Add
SetAutoFailoversupport to the cluster control controller and to thedeployment.Deployerinterface (docker implementation + “not supported” stubs elsewhere). - Introduce
chaos set-auto-failoverandchaos pick-nodeCLI commands. - Improve error logging in
users addby using structured zap logging instead offmt.Sprintf.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/clustercontrol/controller.go | Adds controller method + options for configuring auto-failover via ns_server settings endpoint. |
| deployment/deployer.go | Extends the Deployer interface with SetAutoFailover. |
| deployment/dockerdeploy/deployer.go | Implements SetAutoFailover for docker-based clusters by calling the controller. |
| deployment/localdeploy/deployer.go | Adds SetAutoFailover stub returning “not supported”. |
| deployment/clouddeploy/deployer.go | Adds SetAutoFailover stub returning “not supported”. |
| deployment/caodeploy/deployer.go | Adds SetAutoFailover stub returning “not supported”. |
| cmd/users-add.go | Switches a fatal error path to structured zap logging; removes unused fmt import. |
| cmd/chaos-setautofailover.go | Adds CLI command to configure cluster auto-failover. |
| cmd/chaos-pick-node.go | Adds CLI command to pick a node (optionally orchestrator) for chaos workflows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Westwooo
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.