Add getNodeManager helper func to Deployer#186
Merged
thejcfactor merged 1 commit intoJun 9, 2026
Conversation
Motivation ---------- CollectLogs and getController previously used Nodes[0] to select a cluster node (a.k.a. node manager), but the nodes list includes all containers (load balance, rebalanced-out nodes, etc.). If a non-provisioned node was the first node, a GET /pools/default would return a 404 "unknown pool". Adding a helper function to ensure the selected cluster node is viable removes this undesired behavior. Changes ------- * Added getNodeManager helper func to Deployer * Updated getController() to use new helper func * Update CollectLogs() func to use new helper func
thejcfactor
force-pushed
the
add_get_nodemanager_helper
branch
from
e722c99 to
46cc475
Compare
brett19
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CollectLogs and getController previously used Nodes[0] to select a
cluster node (a.k.a. node manager), but the nodes list includes all
containers (load balance, rebalanced-out nodes, etc.). If a
non-provisioned node was the first node, a GET /pools/default would return
a 404 "unknown pool". Adding a helper function to ensure the selected
cluster node is viable removes this undesired behavior.
Changes