Add support for DNS and Load Balancers#97
Merged
Conversation
This was caused due to the default service list not being applied.
brett19
requested review from
Westwooo,
chvck,
Copilot,
dnault and
programmatix
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring DNS and load balancers for Docker deployments. Key changes include new example YAML files for DNS and load balancer configurations, extensive modifications in the deployment code to integrate DNS record updates and load balancer reconfiguration, and updates to configuration and CLI commands for DNS support.
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/docker-with-lb.yaml | New example YAML file enabling load balancer support. |
| examples/docker-with-dns.yaml | New example YAML file enabling DNS support. |
| deployment/dockerdeploy/*.go | Adjustments to use updated Docker image and container types, and adding DNS and load balancer functionality. |
| cmd/*.go, clusterdef/cluster.go, cbdcconfig | Updates to propagate DNS configuration via flags and YAML. |
Files not reviewed (1)
- go.mod: Language not supported
brett19
force-pushed
the
dns-and-load-balancers
branch
from
b53efb3 to
ec4b34c
Compare
brett19
force-pushed
the
dns-and-load-balancers
branch
from
ec4b34c to
b29261f
Compare
brett19
force-pushed
the
dns-and-load-balancers
branch
from
b29261f to
5495f37
Compare
chvck
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.