CBL-6907: add Start and Stop Listener API#164
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 7 out of 11 changed files in this pull request and generated 2 comments.
Files not reviewed (4)
- servers/jak/android/app/build.gradle: Language not supported
- servers/jak/desktop/app/build.gradle: Language not supported
- servers/jak/webservice/app/build.gradle: Language not supported
- tests/config_java.json: Language not supported
Comments suppressed due to low confidence (1)
servers/jak/shared/common/main/java/com/couchbase/lite/mobiletest/services/ListenerService.java:36
- [nitpick] The method name 'addEndptListener' is abbreviated; consider renaming it to 'addEndpointListener' for improved clarity.
ctxt.addEndptListener(listenerId, listener);
Also, some thread safety in TestContext
borrrden
reviewed
Apr 14, 2025
| maven { url 'https://proget.sc.couchbase.com/maven2/internalmaven' } | ||
| maven { | ||
| url 'https://proget.sc.couchbase.com/maven2/internalmaven' | ||
| content { includeGroupByRegex "com\\.couchbase\\.lite.*" } |
Member
There was a problem hiding this comment.
Ohhh this is an interesting option I like!
borrrden
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, some thread safety in TestContext
This starts and stops a listener. Not clear that it is the one that the tests want: may need to be tweaked....