Java prebuild support#212
Merged
Merged
Conversation
Member
Author
|
A lot of this PR is refactoring desktop and webservice to have a base class since most of their prebuild stuff is identical. |
The issue is that there is no information passed into the teardown about whether or not the test server was downloaded. In the run tests phase it actually downloads the test server and marks it as downloaded as a side effect. However, when stopping this doesn't happen so I added in a sneaky optional argument written in a way that I will continue to notice to both fix the problem and remind me to do a better fix later.
bmeike
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.