Skip to content

API 2.0 spec#222

Merged
bmeike merged 1 commit into
mainfrom
pr/api-2.0
Jun 23, 2025
Merged

API 2.0 spec#222
bmeike merged 1 commit into
mainfrom
pr/api-2.0

Conversation

@bmeike
Copy link
Copy Markdown
Contributor

@bmeike bmeike commented Jun 20, 2025

Replace dataset_version with dataset and blob urls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 20, 2025

Redocly preview

API

This comment was marked as outdated.

Comment thread spec/api/api.yaml Outdated
blob objects and values are the urls from which to obtain the blob files.
type: object
additionalProperties: {}
example: {'photo.thumbnail': 's1.jpg'}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct if this is a url? s1.jpg doesn't look like a url to me.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be corrected to the same style as the dataset property below

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I missed one. Will fix.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR updates the OpenAPI spec to version 2.0.0, deprecates the old dataset_version field, and switches dataset and blob references to URL-based inputs.

  • Bump spec to 2.0.0 and note breaking change in CBLTest-API-Version
  • Deprecate dataset_version and change dataset to accept URLs (including unzipping .zip)
  • Update updatedBlobs descriptions, examples, and component schemas to use URLs
Comments suppressed due to low confidence (3)

spec/api/api.yaml:46

  • The OpenAPI info.version field should be updated to '2.0.0' to match the new Changes section and ensure spec version consistency.
      ```

spec/api/api.yaml:338

  • [nitpick] Consider capitalizing 'URLs' for consistency with standard terminology (e.g., 'the URLs from which to retrieve the blobs').
          the urls from which to retrieve the blobs to be put at the key path location.

spec/api/api.yaml:346

  • [nitpick] Replace the colon after 'refers' with a comma and clarify, e.g., '...blob file to which the blob URL refers, using the value associated with the keypath in the request.'
          The blob object is created from the content of the blob file to which the blob url refers: the value associated

@bmeike bmeike merged commit 94d10a4 into main Jun 23, 2025
4 checks passed
@bmeike bmeike deleted the pr/api-2.0 branch June 23, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants