Peer to peer topology tests #303
Merged
Merged
Conversation
borrrden
requested changes
Nov 7, 2025
| json["port"] = self.__port | ||
|
|
||
| if self.__disable_tls: | ||
| json["disableTLS"] = self.__disable_tls |
Member
There was a problem hiding this comment.
This cannot be simply added without a change in the API spec in the specs folder for v1 (and implementation on ALL platforms: Java and Android are missing). What is the need for disabling TLS anyway?
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback!
I didn’t realise the API spec needed to be updated first - I'll go ahead and add these changes there then?
I’ll also check the Java and Android parts and include the missing changes there.
About disabling TLS: these tests are for the P2P feature, and TLS isn’t a must for them. We can still have a few tests with TLS if needed, but it’s not really necessary for all cases.
Redocly preview |
borrrden
requested changes
Nov 18, 2025
borrrden
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds peer-to-peer topology test coverage and supporting framework improvements, including new test cases, support for disabling TLS on URLEndpointListener and test specs for mesh and loop topologies.
Features added:
tests/QE/test_peer_to_peer_topology.py).spec/QE/test_peer_to_peer_topology.md).