Create a simple_cloud fixture#371
Conversation
|
Is the goal here to be able to run all existing tests with rosmar? Because otherwise I think if you write a new test there is no requirement to use the cloud class. That class was there specifically because setting things up between server and sync gateway is finicky and messy. For rosmar you can just skip straight to SGW db PUT right? |
The goal is to run all the existing tests, the tests all run OK except those that really require a server (XDCR). If you'd rather that I do something hackier like putting: I can do that to make sure that it doesn't accidentally try to contact a couchbase server that might exist and thus not work correctly. To me, these fixtures reduce LOC and complexity but I can understand why this isn't always that way. Another way of thing about this instead of a fixture like this would be to replace the cloud fixture with a method on I can infer rosmarness by asking Sync Gateway, so technically this doesn't even need to be present in the configuration file at all. |
|
If you are ready for this to be reviewed let me know again because the checks are failing |
|
I put this up as an idea of what to do. The code that can go into production is in #375 I mostly want to know if you think this makes things better (or worse). |
75f765c to
fb0a6c8
Compare
fb0a6c8 to
6dd8299
Compare
In order to implement rosmar support into the e2e framework, it makes logical sense that
couchbase_serversis nil. However, all tests that useconfigure_datasetrequire aCouchbaseCloudinstance.This PR only creates a simple_cloud convenience function to allow for a future rosmar upgrade, for all tests that can be run without an actual Couchbase Server instance (most of them).