Skip to content

First draft of upg tests, ignore PR failures#373

Merged
vipbhardwaj merged 14 commits into
mainfrom
sgw-upgrade
Apr 7, 2026
Merged

First draft of upg tests, ignore PR failures#373
vipbhardwaj merged 14 commits into
mainfrom
sgw-upgrade

Conversation

@vipbhardwaj

Copy link
Copy Markdown
Contributor

UPfrade test for SGW.
Currently ignore the failures on focus on how can I handle the code for SGW version switch. I need help with the specific code inside the file ./jenkins/pipelines/QE/upg-sgw/test.sh.

Also I changes the pre-commit-config since it wasn't allowing me to commit code with language as unsupported.

Comment thread jenkins/pipelines/QE/upg-sgw/test.sh Outdated
Comment thread jenkins/pipelines/QE/upg-sgw/topology.json
Comment thread jenkins/pipelines/QE/upg-sgw/setup_test.py
Comment thread tests/QE/test_upg_sgw.py
@vipbhardwaj vipbhardwaj requested a review from RIT3shSapata March 9, 2026 08:16

@borrrden borrrden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really still think this test is trying to do way more than it needs to. If the tests were focused on just sg upgrade they could be so much faster if written in another framework.

Comment thread environment/aws/stop_backend.py Outdated
Comment thread environment/aws/stop_backend.py Outdated
Comment thread jenkins/pipelines/QE/upg-sgw/config.json Outdated
Comment thread jenkins/pipelines/QE/upg-sgw/teardown.sh
@vipbhardwaj

Copy link
Copy Markdown
Contributor Author

There's no change related to your subcomments, but the team and I have decided that this can be kept for a simple upgrade test run quick and basic (~30 min), especially for verification of <= 4.0.0 this is enough.
However, you were right about the fact that a new framework should be devised, as the team has decided too that > 4.0 has significant new features like mixed version mode supporting rolling upgrades that probably the TDK alone cannot test. Hence that is under doing my homework and learning about 4.1.x so as to decide what would be the foundation of the testing there and hence the new framework too.

For now

This PR can be merged to main but I would like to discussed with you as to how you designed and made TDK evolve to where it is now since the infrastructure part of the new-framework is not gonna be just SGW related or UPGRADE testing related.
Requesting your approval on this.

@vipbhardwaj vipbhardwaj requested a review from borrrden March 12, 2026 11:21

@borrrden borrrden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my sanity I will stop commenting on things besides what is changing in the TDK since this is purely in the SGW realm. The changes here are small, and the only weird part is that the orchestrator has sort of "opt out" flags for start while it has "opt in" optional flags for stop.

Comment thread client/src/cbltest/api/syncgateway.py
Comment thread spec/tests/QE/test_rolling_upgrade_sgw.md
Comment thread jenkins/pipelines/QE/upg-sgw/test_rolling.sh
@vipbhardwaj vipbhardwaj merged commit a93611c into main Apr 7, 2026
2 of 4 checks passed
@vipbhardwaj vipbhardwaj deleted the sgw-upgrade branch April 7, 2026 11:40
torcolvin pushed a commit that referenced this pull request Apr 8, 2026
* First draft of upg tests, ignore PR failures

* pre-commit fix + test works

* Removed unnecessary comments

* Added CBL as well

* Changed TS to iOS for Jenkins slave

* Updated Jenkinsfile

* Corrected "platform" field

* Code cleaning

* test: multi-SGW-upg

* test: rolling-upg SGW

* refactor: test runtime + coverage

* fix: mobile OS specified

* fix: added Jenkinsfile_rolling for remote SGW upg job + specific file pointers for each upg job

* refactor: added right IP & creds for greenboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants