Skip to content

fix: SGW 4.0.0 shown as 0.0.0 + keep all-fail runs#388

Merged
vipbhardwaj merged 2 commits into
mainfrom
sgw-version-correction
Apr 21, 2026
Merged

fix: SGW 4.0.0 shown as 0.0.0 + keep all-fail runs#388
vipbhardwaj merged 2 commits into
mainfrom
sgw-version-correction

Conversation

@vipbhardwaj
Copy link
Copy Markdown
Contributor

@vipbhardwaj vipbhardwaj commented Apr 16, 2026

https://jira.issues.couchbase.com/browse/CBG-5293

SGW docs were added properly but the runs for 4.0.0 were shown as 0.0.0 because the build couldn't be fetched perhaps. Since the build might be fetched later, the current fix to support SGW and not trash other platforms is to keep version ONLY if version_components doesn't have two elements.
Which is the current SGW case

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Greenboard result uploads for Sync Gateway runs so that SGW 4.0.0 isn’t reported as 0.0.0 when a build number is missing/unparseable, and adjusts upload behavior to retain SGW runs even when the session has an “overall fail” condition.

Changes:

  • Parse version/build more defensively (default build=0; keep version even when build is missing/unparseable).
  • Use sgw_version for Greenboard version parsing when uploading under the sync-gateway platform.
  • Only skip result uploads on overall failures for non-SGW runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread client/src/cbltest/greenboarduploader.py Outdated
Comment thread client/src/cbltest/greenboarduploader.py
@torcolvin
Copy link
Copy Markdown
Collaborator

What's the root cause of the build showing 0.0.0 ? Can you write a test for the build types as copilot suggests?

One thing I noticed when doing some local testing is that SyncGateway.get_version will not be able to return a version number if it is a dev build

async def get_version(self) -> CouchbaseVersion:
.

A Sync Gateway dev build should never get uploaded to greenboard so that isn't a problem itself, but I wonder where the root cause was.

@borrrden
Copy link
Copy Markdown
Member

A Sync Gateway dev build should never get uploaded to greenboard so that isn't a problem itself, but I wonder where the root cause was.

What does this mean? The E2E tests are meant to validate an internal build. Is that different than a dev build? I didn't design this with sync gateway uploading in mind which means it will need a bit of thought to be able to retrieve what build number it is working with.

Comment thread client/src/cbltest/greenboarduploader.py Outdated
@vipbhardwaj vipbhardwaj requested a review from borrrden April 17, 2026 11:49
@vipbhardwaj vipbhardwaj merged commit a756fb0 into main Apr 21, 2026
5 checks passed
@vipbhardwaj vipbhardwaj deleted the sgw-version-correction branch April 21, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants