fix: SGW 4.0.0 shown as 0.0.0 + keep all-fail runs#388
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes Greenboard result uploads for Sync Gateway runs so that SGW 4.0.0 isn’t reported as 0.0.0 when a build number is missing/unparseable, and adjusts upload behavior to retain SGW runs even when the session has an “overall fail” condition.
Changes:
- Parse version/build more defensively (default build=0; keep version even when build is missing/unparseable).
- Use
sgw_versionfor Greenboard version parsing when uploading under thesync-gatewayplatform. - Only skip result uploads on overall failures for non-SGW runs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
What's the root cause of the build showing 0.0.0 ? Can you write a test for the build types as copilot suggests? One thing I noticed when doing some local testing is that A Sync Gateway dev build should never get uploaded to greenboard so that isn't a problem itself, but I wonder where the root cause was. |
What does this mean? The E2E tests are meant to validate an internal build. Is that different than a dev build? I didn't design this with sync gateway uploading in mind which means it will need a bit of thought to be able to retrieve what build number it is working with. |
https://jira.issues.couchbase.com/browse/CBG-5293
SGW docs were added properly but the runs for 4.0.0 were shown as 0.0.0 because the build couldn't be fetched perhaps. Since the build might be fetched later, the current fix to support SGW and not trash other platforms is to keep version ONLY if
version_componentsdoesn't have two elements.Which is the current SGW case