Proget parameterizing#395
Merged
Merged
Conversation
- SyncGatewayVersion.parse() and EdgeServerVersion.parse(): prevent empty version string (now returns 'unknown'), catch ValueError on non-numeric build numbers, add warning logs for unexpected formats - SyncGateway.get_version() and EdgeServer.get_version(): replace assert with graceful fallback when version string lacks '/' separator, use rsplit to handle multiple slashes - GreenboardUploader.upload(): accept CouchbaseVersion object instead of pre-formatted string to eliminate fragile serialize-then-reparse pattern; use .version/.build_number directly for SGW jobs - greenboard_fixture.py: pass CouchbaseVersion object directly instead of constructing intermediate string - Add unit tests for version parsing edge cases (14 tests) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Prelease versions are picked for CBL in SGW job - For upgrade jobs CBL version only is picked since SGW has a series of defined versions and cannot resort to just picking prerelease
borrrden
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5315
Using proget to parameterize the CBL version picking since its been a pain point for SGW jobs as they are run on a scheduled basis.