Fix C-iOS prebuild not propagating xcodebuild failures#408
Open
pasin wants to merge 1 commit into
Open
Conversation
pasin
commented
May 5, 2026
pasin
commented
Contributor
- Merge xcodebuild stderr into stdout so xcpretty shows errors.
- Wait for both xcodebuild and xcpretty to finish.
- Raise an error if either process exits with a non-zero status.
* Merge xcodebuild stderr into stdout so xcpretty shows errors. * Wait for both xcodebuild and xcpretty to finish. * Raise an error if either process exits with a non-zero status.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the iOS test server prebuild pipelines to correctly surface xcodebuild failures when output is piped through xcpretty, aligning behavior with typical shell pipefail semantics so CI fails when either stage fails.
Changes:
- Merge
xcodebuildstderr into stdout soxcprettyformats and displays errors. - Ensure both
xcprettyandxcodebuildare waited on before proceeding. - Fail the build when either process exits non-zero.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| environment/aws/topology_setup/test_server_platforms/swift_register.py | Pipes combined xcodebuild output into xcpretty and checks both processes’ exit codes. |
| environment/aws/topology_setup/test_server_platforms/c_register.py | Applies the same `xcodebuild |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
borrrden
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.