Added retry loop#424
Open
vipbhardwaj wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves stability of the QE xattrs concurrency test by adding a bounded retry loop to wait for Sync Gateway to import SDK-written documents before asserting document visibility.
Changes:
- Added a ~30s polling loop around
sg.get_all_documents()to wait for imported docs to become visible. - Improved assertion messaging to include the polling budget context.
…ass function instead
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
56
to
58
| self.mark_test_step("Verify import_count in expvars") | ||
| expvars = await sg._send_request("get", "/_expvar") | ||
| assert isinstance(expvars, dict) | ||
| expvars_dict = cast(dict, expvars) | ||
| import_count = ( | ||
| expvars_dict.get("syncgateway", {}) | ||
| .get("per_db", {}) | ||
| .get(sg_db, {}) | ||
| .get("shared_bucket_import", {}) | ||
| .get("import_count", 0) | ||
| ) | ||
| import_count = await sg.wait_for_import_count(sg_db, num_docs) | ||
| assert import_count != 0, f"Expected import_count > 0, got {import_count}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5486