Latency measures#24
Open
chiragbytes7 wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
pure go implementation, no transitive deps. |
pavlosg
reviewed
May 12, 2026
this timeout will be used to set the max value in the ldr histogram, prevents circular dependency
chiragbytes7
force-pushed
the
latency-measures-elastic
branch
from
5ba2f4f to
9975f36
Compare
Collaborator
|
I'm not convinced that persisting those values somewhere no-one will look is useful. It would be better to log it. (logs are already persisted) |
Contributor
Author
|
okay, making the change to just log them. removed the extra struct used for marshalling etc. |
chiragbytes7
force-pushed
the
latency-measures-elastic
branch
from
9975f36 to
dfa5418
Compare
pavlosg
reviewed
Jun 11, 2026
|
|
||
| func (db *database) SetOptions(opt *gorgon.Options) error { | ||
| db.options = opt | ||
| opt.OperationTimeout = *db.config.Timeout // Set Timeout for upper bound of latency histogram |
Collaborator
There was a problem hiding this comment.
That's a backwards way to do it. If you want to have the timeout in the options, make it explicit in gorgon. Then use the gorgon option in the couchbase db (i.e. remove the timeout from the db config).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Percentile Latency measures with the Go implementation of HDR histogram by Elastic