Add cbcollect logging and network trace capture functionality#7
Open
chiragbytes7 wants to merge 3 commits into
Open
Add cbcollect logging and network trace capture functionality#7chiragbytes7 wants to merge 3 commits into
chiragbytes7 wants to merge 3 commits into
Conversation
chiragbytes7
force-pushed
the
cbcollect-network-capture
branch
from
af5f192 to
5056ef2
Compare
pavlosg
reviewed
Mar 16, 2026
There was a problem hiding this comment.
Pull request overview
Adds RPC-driven cbcollect log collection and network trace (tshark) capture to the Couchbase Gorgon runner, and introduces new CLI flags intended to improve runner setup/teardown behavior.
Changes:
- Register new worker RPC handlers for cbcollect and network trace capture/stop.
- Add CLI options and database-side helpers to trigger cbcollect and start/stop network capture across nodes.
- Adjust runner teardown/check behavior (including optional non-zero exit on consistency-check failures).
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/gorgon_couchbase/main.go | Registers new RPC handlers on worker nodes. |
| src/gorgon_couchbase/kv/db.go | Starts/stops capture and runs cbcollect via RPC clients; wires to Options flags. |
| src/gorgon/rpcs/cbcollect_rpc.go | Implements RPC method to run cbcollect_info and write a zip file. |
| src/gorgon/rpcs/networktrace_rpc.go | Implements RPC methods to start tshark capture and stop it. |
| src/gorgon/interface.go | Adds Options fields for log directory, cbcollect, capture, and error-on-test-fail. |
| src/gorgon/cmd/main.go | Adds new CLI flags to populate the new Options fields. |
| src/gorgon/cmd/runner.go | Adds teardown-on-partial-setup logic and optional error return on check failures. |
| docker/gorgon_couchbase/node/Dockerfile | Installs tshark and creates capture/log directory in the node image. |
| docker/gorgon_couchbase/control/run.sh | Enables cbcollect + network capture flags in one run scenario. |
| src/gorgon/go.sum | Updates porcupine dependency checksums. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
chiragbytes7
force-pushed
the
cbcollect-network-capture
branch
6 times, most recently
from
9b7031d to
7956414
Compare
pavlosg
reviewed
Mar 19, 2026
chiragbytes7
force-pushed
the
cbcollect-network-capture
branch
2 times, most recently
from
13a837c to
2b42c2b
Compare
pavlosg
reviewed
Mar 24, 2026
chiragbytes7
force-pushed
the
cbcollect-network-capture
branch
3 times, most recently
from
e7dea27 to
0d57ca2
Compare
chiragbytes7
force-pushed
the
cbcollect-network-capture
branch
from
0d57ca2 to
c17c5e1
Compare
Contributor
Author
|
rebased and forced push this branch on upstream/main |
chiragbytes7
force-pushed
the
cbcollect-network-capture
branch
from
c17c5e1 to
c63336d
Compare
Contributor
Author
|
flag parsing for cli option for "Allow terminating with non-zero status when a test fails" was missing, amended the latest commit and force pushed |
Contributor
Author
|
added test timeout handling here, set and return exit code 3 |
Fix incomplete runner setup bug by safely aborting
added constants to represent timeouts for both linearizability and sequential, test failures still have higher priority over test timeouts
chiragbytes7
force-pushed
the
cbcollect-network-capture
branch
from
1462980 to
9d037c6
Compare
Contributor
Author
|
changed the default dir for artefacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incomplete runner setup bug by safely aborting