FEAT: add ability to send pach to synth through CC messages - #3
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to send synthesizer patches via MIDI Control Change (CC) messages. The feature enables users to apply a patch file (.prm) to a synthesizer by converting patch parameters to appropriate CC messages and sending them through MIDI.
- Added a new CLI command
send-patchto apply patch files to the synth through MIDI - Implemented CC message generation logic in the JU06AState class
- Added parameter scaling logic to handle different value ranges between patch files and CC messages
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/text2synth/state.py | Added CC message generation method and parameter scaling constants |
| main.py | Added CLI command and MIDI output functionality for sending patches |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| patch_attribute = data["patch_attribute"] | ||
| value = getattr(self, patch_attribute) | ||
| if patch_attribute in DOUBLE_ATTRIBUTES: |
There was a problem hiding this comment.
The division by 2 for double attributes lacks explanation. Consider adding a comment explaining why these values need to be halved for CC transmission.
Suggested change
| if patch_attribute in DOUBLE_ATTRIBUTES: | |
| if patch_attribute in DOUBLE_ATTRIBUTES: | |
| # Double attributes have a range of 0..255 at the synth level, but MIDI CC messages only support 0..127. | |
| # Therefore, we divide by 2 to fit the value into the MIDI CC range for transmission. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to use: