Skip to content

Remove deprecation warning for pandas #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carlosal1015
Copy link

No description provided.

@eguidotti
Copy link

@martinbenes1996 Would you be able to check this and push it to PyPI?

@martinbenes1996
Copy link
Collaborator

This is because pandas.DataFrame.append() is deprecated from 1.4.0. I changed it to pandas.concat(). Will

Btw. thanks to unit tests I discovered there are quite some new columns.

Modified keys:

  • currency renamed to iso_currency
  • key distinguished to key_jhu_csse, key_nuts, key_local

New keys

  • elderly_people_protection
  • people_fully_vaccinated
  • facial_coverings
  • key_gadm
  • government_response_index
  • economic_support_index
  • vaccination_policy
  • containment_health_index
  • people_vaccinated

The new keys are not included in the src dataframe.

@eguidotti
Copy link

Thanks a lot! Yes, the src file has been deprecated and those variables are documented here and the data sources are here.

@martinbenes1996
Copy link
Collaborator

Great. Perhaps it would be a good idea to change that covid19() returns only the data without src frame, if this is deprecated.

@eguidotti
Copy link

Good point, yes that's definitely a good idea. Also, the new version on PyPI should be 3.0.0 to indicate that it is a major change and it is consistent with the latest version of the data hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants