fix: removing legacy-peer-deps flag and adding Docker build kit in readme.md#13
Open
lgahdl wants to merge 1 commit into
Open
Conversation
fix: resolve npm peer dependency conflict via overrides for ethers v6 docs: update prerequisites and remove --legacy-peer-deps from setup steps
mfw78
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses two developer experience issues identified during re-testing. Neither is a blocker but both affect the out-of-the-box setup experience.
Changes
# syntax=docker/dockerfile:1frontend pragma tomodules/services/Dockerfile,modules/services/playground/Dockerfile.cowswap, andmodules/services/playground/Dockerfile.explorer— this enables BuildKit automatically, making--mount=type=cachework without requiringDOCKER_BUILDKIT=1to be set manuallyDOCKER_BUILDKIT=1"overrides": { "ethers": "^6.9.0" }to the rootpackage.jsonto resolve the peer dependency conflict betweenethers@^6(devDependencies) and@cowprotocol/contracts/@cowprotocol/app-data(which declareethers@^5as a peer dep). Neither package is imported in TypeScript — they areFoundry/Solidity dependencies only — so forcing ethers v6 across the tree is safe
--legacy-peer-depsfrom thenpm installstep in the READMEHow to test
npm installfrom the repo root — should succeed with noERESOLVEerror and no flags requireddocker buildagainst any of the three modified Dockerfiles without settingDOCKER_BUILDKIT=1— build should succeed and--mount=type=cachelayers should be recognized