-
Notifications
You must be signed in to change notification settings - Fork 21
Add BNB, Linea & Plasma to networks.json #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are requested because the transaction hash for linea (59144) is incorrect; it should be 0x120ac507b9973897669829e6865fc95db3dd7dac8e6ece826d8350f870f01882
All the other transaction hashes/addresses are correct.
to observe actual changes without sorting effect, I used jq --sort-keys < networks.json > networks-sorted.json on both the branch and main.
using this method I compared the 3 deployed networks. I verified that the contracts were indeed deployed and bytecode matched that which was built in this repo.
to compare the bytecode, I used the reported transaction hash to ensure the input data was the same. wrote up this one-liner to help with this common task:
for x in $(jq -r 'to_entries | map("\(.key):\(.value."56".transactionHash)")[]' < networks.json); do IFS=':' read -r k v <<< $x; [[ $(cast tx $v input --rpc-url https://bsc-rpc.publicnode.com) == $(cast tx $(jq -r ".$k.\"1\".transactionHash" < networks.json) input --rpc-url https://ethereum-rpc.publicnode.com) ]] && [[ $(cast tx $v to --rpc-url https://bsc-rpc.publicnode.com) == '0x4e59b44847b379578588920cA78FbF26c0B4956C' ]] && echo good $k || echo MISMATCH $k; done;
for verifying contract source codes:
for x in $(jq -r 'to_entries | map("\(.key):\(.value."56".address)")[]' < networks.json); do IFS=':' read -r k v <<< $x; cast source $v --chain-id 56 --api-key <etherscan-key> >> /dev/null && echo source $k || echo MISS $k; done
(repeat for all networks)
Fix copypaste error.
Great catch, there was a copypaste err on TWAP for Linea. 💪 Fixed. |
Description
For BNB, contracts were deployed and verified, but networks.json wasn't up to date. Fixed that.
Also deployed & verified Linea, Plasma & added to networks.json + sorted the file.