Skip to content

Conversation

@fafk
Copy link
Contributor

@fafk fafk commented Sep 16, 2025

Description

For BNB, contracts were deployed and verified, but networks.json wasn't up to date. Fixed that.

Also deployed & verified Linea, Plasma & added to networks.json + sorted the file.

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@fafk
Copy link
Contributor Author

fafk commented Sep 16, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Sep 16, 2025
@fafk fafk enabled auto-merge (squash) September 16, 2025 08:24
@fafk fafk changed the title Add bnb to networks.json Add BNB & Linea to networks.json Oct 29, 2025
@fafk fafk changed the title Add BNB & Linea to networks.json Add BNB, Linea & Plasma to networks.json Oct 29, 2025
Copy link

@kaze-cow kaze-cow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are requested because the transaction hash for linea (59144) is incorrect; it should be 0x120ac507b9973897669829e6865fc95db3dd7dac8e6ece826d8350f870f01882

All the other transaction hashes/addresses are correct.

to observe actual changes without sorting effect, I used jq --sort-keys < networks.json > networks-sorted.json on both the branch and main.

using this method I compared the 3 deployed networks. I verified that the contracts were indeed deployed and bytecode matched that which was built in this repo.

to compare the bytecode, I used the reported transaction hash to ensure the input data was the same. wrote up this one-liner to help with this common task:

for x in $(jq -r 'to_entries | map("\(.key):\(.value."56".transactionHash)")[]' < networks.json); do IFS=':' read -r k v <<< $x; [[ $(cast tx $v input --rpc-url https://bsc-rpc.publicnode.com) == $(cast tx $(jq -r ".$k.\"1\".transactionHash" < networks.json) input --rpc-url https://ethereum-rpc.publicnode.com) ]] && [[ $(cast tx $v to --rpc-url https://bsc-rpc.publicnode.com) == '0x4e59b44847b379578588920cA78FbF26c0B4956C' ]] && echo good $k || echo MISMATCH $k; done;

for verifying contract source codes:

for x in $(jq -r 'to_entries | map("\(.key):\(.value."56".address)")[]' < networks.json); do IFS=':' read -r k v <<< $x; cast source $v --chain-id 56 --api-key <etherscan-key> >> /dev/null && echo source $k || echo MISS $k; done

(repeat for all networks)

@fafk
Copy link
Contributor Author

fafk commented Oct 30, 2025

Changes are requested because the transaction hash for linea (59144) is incorrect; it should be 0x120ac507b9973897669829e6865fc95db3dd7dac8e6ece826d8350f870f01882

All the other transaction hashes/addresses are correct.

Great catch, there was a copypaste err on TWAP for Linea. 💪 Fixed.

@fafk fafk merged commit 471ca59 into main Oct 30, 2025
5 checks passed
@fafk fafk deleted the add-bnb-to-network-json branch October 30, 2025 06:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants