chore: migrate E2E 0xTrade test to Foundry #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meetmangukiya
force-pushed
the
e2e-migrate-0xTrade
branch
from
4a9bb87 to
ba81930
Compare
Author
|
I couldn't find anything in their news blog, might be too old, maybe there was no blog post about it, but they integrated v4 of their contracts and went live on March 1st, 2021 https://0x.org/post/0x-api-swap-now-supports-0x-protocol-v4 |
mfw78
approved these changes
Sep 29, 2024
Contributor
|
Please also remove the |
meetmangukiya
force-pushed
the
e2e-migrate-0xTrade
branch
from
dcf8d68 to
f8d6d93
Compare
Author
|
removed and rebased |
mfw78
force-pushed
the
e2e-migrate-0xTrade
branch
from
f8d6d93 to
7983e39
Compare
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@0x/[email protected] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the 0xTrade e2e test to foundry. Depends on #215.
Test Plan
CI
Related Issues
Closes #131 #132