Skip to content

Conversation

@squadgazzz
Copy link
Contributor

@squadgazzz squadgazzz commented Jun 11, 2025

Description

This PR updates the GPv2Settlement SC deployment script to default to the deterministic Balancer Vault address(0xBA12222222228d8Ba445958a75a0704d566BF2C8) when it is not actually deployed yet.

While the GPv2Settlement contract accepts a Balancer Vault address in its constructor, it does not strictly require the Vault to be deployed for basic ERC20 settlement functionality. This was confirmed in internal discussion:

  • On Gnosis Chain, we used the Settlement contract before the Balancer Vault was even available.
  • The contract only interacts with the Vault for advanced balance sources (non-ERC20 tokens), which are not required for standard usage.
  • Vault-dependent logic is guarded and will not be triggered unless certain preconditions (e.g. balanceOpCount > 0) are met

Test Plan

Created an Avalanche fork on Tenderly before the Balancer Vault deployment, and the deployment worked well: https://dashboard.tenderly.co/cow-protocol/barn/testnet/14090eef-bc20-43fc-994d-2353743159cb

Potential risks

SAFE core contract addresses on ZK rollups differ from those on optimistic ones. Not sure if there is a chance that the Balancer Vault will be deployed later with a different address.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@squadgazzz
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jun 11, 2025
@squadgazzz squadgazzz marked this pull request as ready for review June 11, 2025 18:23
@squadgazzz squadgazzz requested a review from a team as a code owner June 11, 2025 18:23
@squadgazzz squadgazzz merged commit 39d7f4d into main Jun 12, 2025
7 checks passed
@squadgazzz squadgazzz deleted the use-default-balancer-vault branch June 12, 2025 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants