-
Notifications
You must be signed in to change notification settings - Fork 48
fix(ci): lock foundry version #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
now that foundry has stable releases, there is no reason to subject ourselves to the instability of the nightly releases. this PR proposes locking to the current foundry release v1.3.5, and we can manually bump it as it makes sense. as it so happens, the current nightly release seems to be changing the lint rules or something and the CI is currently failing with `main` branch code.
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
anxolin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
now that foundry has stable releases, there is no reason to subject ourselves to the instability of the nightly releases. this PR proposes locking to the current foundry release v1.3.5, and we can manually bump it as it makes sense.
as it so happens, the current nightly release seems to be changing the lint rules or something and the CI is currently failing with
mainbranch code.