feat(flash-loans): support Mainnet, Gnosis, and Base for AAVE #657
Conversation
WalkthroughTests and Aave constants were updated: tests now target GNOSIS_CHAIN instead of SEPOLIA; Aave addresses/hooks were refactored to typed per-chain Records and per-type hook maps; ADAPTER_DOMAIN_NAME was renamed to "AaveV3AdapterFactory"; DOMAIN_SEPARATOR ABI metadata was enriched. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 GitHub Packages PublishedLast updated: Nov 7, 2025, 06:31:44 AM UTC The following packages have been published to GitHub Packages with pre-release version
InstallationThese packages require authentication to install from GitHub Packages. First, create a # Create .npmrc file in your project root
echo "@cowprotocol:registry=https://npm.pkg.github.com" > .npmrc
echo "//npm.pkg.github.com/:_authToken=YOUR_GITHUB_TOKEN" >> .npmrcTo get your GitHub token:
Then install any of the packages above, either by exact version (i.e. # Yarn
yarn add npm:@cowprotocol/cow-sdk@pr-657
# pnpm
pnpm install npm:@cowprotocol/cow-sdk@pr-657
# NPM
npm install npm:@cowprotocol/cow-sdk@pr-657Update to the latest version (only if you used the tag)Every commit will publish a new package. To upgrade to the latest version, run: # Yarn
yarn upgrade @cowprotocol/cow-sdk
# pnpm
pnpm update @cowprotocol/cow-sdk
# NPM
npm update @cowprotocol/cow-sdkView PackagesYou can view the published packages at: https://github.com/cowprotocol/cow-sdk/packages |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/flash-loans/src/aave/AaveCollateralSwapSdk.test.ts (1)
162-177: Consider expanding test coverage to new chains.While the tests now validate GNOSIS_CHAIN functionality, the PR also adds support for MAINNET (chainId 1) and BASE (chainId 8453). Consider adding similar test coverage for these chains to ensure consistent behavior across all newly supported networks.
packages/flash-loans/src/aave/const.ts (1)
26-31: Add runtime validation for empty adapter factory addresses.The
AAVE_ADAPTER_FACTORYmapping contains empty strings for unsupported chains (9 of 12SupportedChainIdvalues). While TypeScript compiles successfully, all five runtime accesses (lines 224, 226, 354, 489, 512) passchainIddirectly toAAVE_ADAPTER_FACTORY[chainId]without validating the result. If an unsupported chain reaches these methods, the empty string will propagate into blockchain interactions, causing silent failures or unclear errors.Recommend adding explicit validation at SDK entry points (e.g.,
collateralSwap,getOrderPostingSettings) or before each blockchain interaction to ensurechainIdis in the supported set or throw a clear error early.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
packages/contracts-ts/src/generated/packageVersion.tsis excluded by!**/generated/**
📒 Files selected for processing (3)
packages/flash-loans/src/aave/AaveCollateralSwapSdk.test.ts(19 hunks)packages/flash-loans/src/aave/abi/AaveAdapterFactory.ts(1 hunks)packages/flash-loans/src/aave/const.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: alfetopito
Repo: cowprotocol/cow-sdk PR: 391
File: src/trading/getEthFlowTransaction.ts:80-85
Timestamp: 2025-08-12T09:15:28.459Z
Learning: In the CoW SDK codebase, ETH_FLOW_ADDRESSES and BARN_ETH_FLOW_ADDRESSES are typed as Record<SupportedChainId, string>, which requires all SupportedChainId enum values to have corresponding string entries. TypeScript compilation will fail if any chainId is missing from these mappings, making runtime guards for missing addresses unnecessary in these specific cases.
📚 Learning: 2025-08-12T09:15:28.459Z
Learnt from: alfetopito
Repo: cowprotocol/cow-sdk PR: 391
File: src/trading/getEthFlowTransaction.ts:80-85
Timestamp: 2025-08-12T09:15:28.459Z
Learning: In the CoW SDK codebase, ETH_FLOW_ADDRESSES and BARN_ETH_FLOW_ADDRESSES are typed as Record<SupportedChainId, string>, which requires all SupportedChainId enum values to have corresponding string entries. TypeScript compilation will fail if any chainId is missing from these mappings, making runtime guards for missing addresses unnecessary in these specific cases.
Applied to files:
packages/flash-loans/src/aave/AaveCollateralSwapSdk.test.tspackages/flash-loans/src/aave/const.ts
🧬 Code graph analysis (2)
packages/flash-loans/src/aave/AaveCollateralSwapSdk.test.ts (1)
packages/flash-loans/src/aave/const.ts (1)
AAVE_ADAPTER_FACTORY(26-31)
packages/flash-loans/src/aave/const.ts (1)
packages/config/src/chains/const/utils.ts (1)
mapAddressToSupportedNetworks(16-18)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Publish to GitHub Packages
- GitHub Check: test
- GitHub Check: Build Package
- GitHub Check: eslint
🔇 Additional comments (5)
packages/flash-loans/src/aave/abi/AaveAdapterFactory.ts (1)
169-180: LGTM! ABI metadata improvements.The additions of explicit
type,inputs, andinternalTypefields make the DOMAIN_SEPARATOR ABI entry more complete and consistent with TypeScript typing conventions. No functional changes.packages/flash-loans/src/aave/const.ts (3)
33-50: LGTM! Well-structured adapter hook constants.The three adapter hook constants follow a consistent pattern with typed
Record<SupportedChainId, string>mappings. The addresses for GNOSIS_CHAIN, MAINNET, and BASE match the PR objectives. The use ofmapAddressToSupportedNetworks('')ensures all chain IDs are covered while keeping the supported chains explicit.Based on learnings: The
Record<SupportedChainId, string>typing ensures TypeScript compilation will fail if any chainId is missing, making these mappings type-safe.
12-25: Question: Intentional partial chain support?I notice that
AAVE_POOL_ADDRESSincludes addresses for chains like ARBITRUM_ONE, AVALANCHE, BNB, POLYGON, LINEA, and PLASMA, but the correspondingAAVE_ADAPTER_FACTORYand adapter hook constants only support GNOSIS_CHAIN, MAINNET, and BASE. Is this intentional partial support, or are the other chains planned for future PRs?
12-25: AAVE pool addresses verified successfully.All three pool addresses match official Aave V3 documentation: Gnosis Chain (0xb50201558B00496A145fE76f7424749556E326D8), Ethereum Mainnet (0x87870Bca3F3fD6335C3F4ce8392D69350B4fA4E2), and Base (0xA238Dd80C259a72e81d7e4664a9801593F98d1c5). The addresses are properly scoped and referenced in tests.
packages/flash-loans/src/aave/AaveCollateralSwapSdk.test.ts (1)
95-106: Addresses verified—chainId migration to GNOSIS_CHAIN is correct.The test correctly references
AAVE_ADAPTER_FACTORY[SupportedChainId.GNOSIS_CHAIN](address0x7f230F7Cee38ca371b871B74B3C6ded4932A2f93) at all four locations: lines 215, 250, 301, and 650. The defined address in const.ts matches all test usages, and the migration from SEPOLIA to GNOSIS_CHAIN aligns with the officially supported Aave V3 deployment on Gnosis Chain.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/flash-loans/src/aave/const.ts(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: alfetopito
Repo: cowprotocol/cow-sdk PR: 391
File: src/trading/getEthFlowTransaction.ts:80-85
Timestamp: 2025-08-12T09:15:28.459Z
Learning: In the CoW SDK codebase, ETH_FLOW_ADDRESSES and BARN_ETH_FLOW_ADDRESSES are typed as Record<SupportedChainId, string>, which requires all SupportedChainId enum values to have corresponding string entries. TypeScript compilation will fail if any chainId is missing from these mappings, making runtime guards for missing addresses unnecessary in these specific cases.
Learnt from: shoom3301
Repo: cowprotocol/cow-sdk PR: 642
File: packages/bridging/src/BridgingSdk/BridgingSdk.ts:124-144
Timestamp: 2025-11-06T11:26:21.337Z
Learning: In the cow-sdk bridging module (packages/bridging/), all bridge providers return ChainInfo objects that are singleton instances imported from cowprotocol/sdk-config. The chain objects (mainnet, arbitrumOne, base, optimism, polygon, avalanche, gnosisChain, etc.) are exported as constants from packages/config/src/chains/details/ and are shared across all providers. This singleton pattern makes object reference comparison (e.g., with Array.includes()) safe for deduplicating networks returned by multiple providers, as the same chain will always be represented by the same object reference.
<!--
📚 Learning: 2025-08-12T09:15:28.459Z
Learnt from: alfetopito
Repo: cowprotocol/cow-sdk PR: 391
File: src/trading/getEthFlowTransaction.ts:80-85
Timestamp: 2025-08-12T09:15:28.459Z
Learning: In the CoW SDK codebase, ETH_FLOW_ADDRESSES and BARN_ETH_FLOW_ADDRESSES are typed as Record<SupportedChainId, string>, which requires all SupportedChainId enum values to have corresponding string entries. TypeScript compilation will fail if any chainId is missing from these mappings, making runtime guards for missing addresses unnecessary in these specific cases.
Applied to files:
packages/flash-loans/src/aave/const.ts
🧬 Code graph analysis (1)
packages/flash-loans/src/aave/const.ts (1)
packages/config/src/chains/const/utils.ts (1)
mapAddressToSupportedNetworks(16-18)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Publish to GitHub Packages
- GitHub Check: eslint
🔇 Additional comments (3)
packages/flash-loans/src/aave/const.ts (3)
26-50: LGTM! Type-safe per-chain adapter mappings.The adapter factory and hook constants are properly structured as
Record<SupportedChainId, string>, which ensures compile-time completeness for all supported chains. The pattern of usingmapAddressToSupportedNetworks('')with chain-specific overrides is type-safe and consistent across all adapter constants. The deployed addresses match those documented in the PR description.Based on learnings.
19-22: Addresses verified as correct—no changes needed.The Aave V3 Pool address (0x794a61358D6845594F94dc1DB02A252b5b4814aD) is correctly deployed identically across Arbitrum One, Avalanche, and Polygon. The code is accurate.
13-25: The original review comment mischaracterizes the code structure and should be disregarded.The analysis incorrectly states that AAVE_ADAPTER_FACTORY "only provides addresses for GNOSIS_CHAIN, MAINNET, and BASE" implying missing chains. In reality, the
mapAddressToSupportedNetworks('')spread operator ensures all 11 SupportedChainId values are present in the Record, per TypeScript's requirement. Only 3 chains have non-empty adapter addresses; the rest have empty strings.The actual concern (empty string handling) is valid but was misidentified. AAVE_ADAPTER_FACTORY has empty strings for 8 chains (ARBITRUM_ONE, AVALANCHE, BNB, POLYGON, LINEA, PLASMA, SEPOLIA, LENS), and these empty strings are used directly at lines 224–226 without validation.
However, this is a code review issue for the calling code, not the constants file itself—the constants are correctly structured per the codebase patterns.
Likely an incorrect or invalid review comment.
Network: gnosis
Chain ID: 100
Deployed Contracts:
AaveV3AdapterFactory: 0x7f230F7Cee38ca371b871B74B3C6ded4932A2f93
CollateralSwapAaveV3Adapter: 0x837aA74e8daf7Fd7160f078ca455a67B7F441E4b
DebtSwapAaveV3Adapter: 0xC9A495A17B1eeC18AE0f0865840B8fd3f8a9DE3F
RepayWithCollateralAaveV3Adapter: 0x2890CE372f3a397B6f3BB3a71B1836A6F3F33657
Network: ethereum
Chain ID: 1
Deployed Contracts:
AaveV3AdapterFactory: 0x22E08c56a6799e28e7b05A117D853B9b46abc017
CollateralSwapAaveV3Adapter: 0xFEb471EC22E5572dbb44229301c266f4C305A78a
DebtSwapAaveV3Adapter: 0x238f57A2c3F0696fB20295075a0F9A18EfC67D3a
RepayWithCollateralAaveV3Adapter: 0x9eB0ffd318e862D344792a8e589e8393E8bEd96F
Network: base
Chain ID: 8453
Deployed Contracts:
AaveV3AdapterFactory: 0xc5D68e305e0b5998f895e34d4440954072F285B6
CollateralSwapAaveV3Adapter: 0xBb45A7898A6f06a9c148BfeD0C103140F0079cd9
DebtSwapAaveV3Adapter: 0xaCbd34fAB78BD6C8738eb32dDAFd688df98CD2E3
RepayWithCollateralAaveV3Adapter: 0x1549445700D0Cb2D7Ce85ECd5a7FD7Ba4a3D40A7
Pool addresses are taken from https://aave.com/docs/resources/addresses
Summary by CodeRabbit
Tests
Chores