Skip to content

feat: add locale display names for consistent language representation… #6561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shoom3301 merged 4 commits into from
Dec 3, 2025
Merged

feat: add locale display names for consistent language representation… #6561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
390562b
feat: add locale display names for consistent language representation…
fairlighteth Nov 26, 2025
b47bdcc
Merge branch 'develop' into fix/language-labels
fairlighteth Nov 26, 2025
d8d7ee1
Merge branch 'develop' into fix/language-labels
fairlighteth Nov 28, 2025
3a9d6df
Merge branch 'develop' into fix/language-labels
fairlighteth Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions libs/common-const/src/locales.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,10 @@ export const SUPPORTED_LOCALES = [
export type SupportedLocale = (typeof SUPPORTED_LOCALES)[number] | 'pseudo'

export const DEFAULT_LOCALE: SupportedLocale = 'en-US'

// Override display names shown in language selectors to ensure consistent wording
export const LOCALE_DISPLAY_NAMES: Partial<Record<SupportedLocale, string>> = {
'en-US': 'English (US)',
'es-ES': 'Español (España)',
'ru-RU': 'Русский (Россия)',
}
6 changes: 6 additions & 0 deletions libs/ui/src/pure/MenuBar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import IMG_ICON_MENU_DOTS from '@cowprotocol/assets/images/menu-grid-dots.svg'
import IMG_ICON_MENU_HAMBURGER from '@cowprotocol/assets/images/menu-hamburger.svg'
import IMG_ICON_SETTINGS_GLOBAL from '@cowprotocol/assets/images/settings-global.svg'
import IMG_ICON_X from '@cowprotocol/assets/images/x.svg'
import { LOCALE_DISPLAY_NAMES } from '@cowprotocol/common-const'
import { useMediaQuery, useOnClickOutside } from '@cowprotocol/common-hooks'
import { addBodyClass, removeBodyClass } from '@cowprotocol/common-utils'

Expand Down Expand Up @@ -102,6 +103,11 @@ const DAO_NAV_ITEMS: MenuItem[] = [
]

const getLanguageName = (locale: string): string => {
const override = LOCALE_DISPLAY_NAMES[locale as keyof typeof LOCALE_DISPLAY_NAMES]
if (override) {
return override
}

const display = new Intl.DisplayNames([locale], { type: 'language' })
const languageName = display.of(locale)

Expand Down