Skip to content

feat: add protocol fee descriptions in multiple languages #6563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shoom3301 merged 7 commits into from
Dec 3, 2025
Merged

feat: add protocol fee descriptions in multiple languages #6563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81adc31
feat: add protocol fee descriptions in multiple languages
fairlighteth Nov 26, 2025
99f694a
fix: improve Spanish translations for swap and protocol fee descriptions
fairlighteth Nov 26, 2025
2ba5835
fix: remove redundant protocol fee descriptions and add new translati…
fairlighteth Nov 26, 2025
affe48a
fix: enhance Russian translation for protocol fee description
fairlighteth Nov 26, 2025
7f2892c
Merge branch 'develop' into feat/protocol-fee-translation
fairlighteth Nov 27, 2025
6ede31f
Merge branch 'develop' into feat/protocol-fee-translation
fairlighteth Nov 28, 2025
0a83f48
Merge remote-tracking branch 'origin/develop' into feat/protocol-fee-…
fairlighteth Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions apps/cowswap-frontend/src/locales/es-ES.po
View file
Open in desktop
Copy link
Contributor

@cowmarketing cowmarketing Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would translate this

Swap and bridge costs are at least {formattedFeePercentage}% of the swap amount"

To the follwoing:

Los costos de Swap y Bridge seran por los menos {formattedFeePercentage}% del monto de intercambio

Copy link
Contributor

@cowmarketing cowmarketing Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are things that imo dont have a direct translation or dont need one

Copy link
Contributor Author

@fairlighteth fairlighteth Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing. Addressed in 4af1253

Copy link
Contributor

@cowmarketing cowmarketing Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one:

msgid ""
"The fee, applied only if the trade is executed, in order to incentivize a "
"strong solver competition that provides ecosystem leading prices."

I would translate it like this:

"Comisión aplicada solo en el caso de que se ejecute la operación, para incentivar una "
"competición sólida de solvers la cual ofrece los precios líderes del ecosistema."

however note, that my reading makes me thing this spanish is Latino spanish and not spain spanish, and I am going with my spain spanish

Copy link
Contributor Author

@fairlighteth fairlighteth Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing. Addressed in 4af1253

Original file line number Diff line number Diff line change
Expand Up @@ -2554,6 +2554,10 @@ msgstr "Resumen de tokens"
msgid "Enter slippage percentage between {min}% and {max}%"
msgstr "Introduzca el porcentaje de deslizamiento entre {min}% y {max}%"

#: apps/cowswap-frontend/src/modules/trade/pure/ProtocolFeeRow/index.tsx
msgid "Protocol fee ({protocolFeeAsPercent}%)"
msgstr "Comisión del protocolo ({protocolFeeAsPercent}%)"

#: apps/cowswap-frontend/src/modules/orderProgressBar/pure/TransactionSubmittedContent/SurplusModal.tsx
msgid "Learn how"
msgstr "Aprende cómo"
Expand Down Expand Up @@ -2748,6 +2752,10 @@ msgstr "Alertas de trading activadas"
msgid "gas"
msgstr "gas"

#: apps/cowswap-frontend/src/common/pure/ReceiveAmountInfo/index.tsx
msgid "Protocol fee"
msgstr "Comisión del protocolo"

#: apps/cowswap-frontend/src/modules/hooksStore/pure/HookListItem/index.tsx
msgid "details"
msgstr "detalles"
Expand Down Expand Up @@ -3289,7 +3297,7 @@ msgstr "Aprobar el token para continuar."

#: apps/cowswap-frontend/src/modules/trade/pure/ProtocolFeeRow/index.tsx
msgid "This {protocolFeeBps} BPS fee incentivizes solvers to find better prices for users. It is only applied if the trade is executed."
msgstr ""
msgstr "Esta comisión de {protocolFeeBps} BPS incentiva a los solvers a encontrar mejores precios para los usuarios. Solo se aplica si se ejecuta la operación."

#: apps/cowswap-frontend/src/modules/accountProxy/pure/AccountCard/DefaultAccountContent.tsx
msgid "Recoverable value"
Expand Down Expand Up @@ -6271,7 +6279,7 @@ msgstr "Aprende más"

#: apps/cowswap-frontend/src/modules/tradeWidgetAddons/containers/HighFeeWarning/highFeeWarningHelpers.ts
msgid "Swap and bridge costs are at least {formattedFeePercentage}% of the swap amount"
msgstr "Los costos de intercambio y puente son por lo menos {formattedFeePercentage}% del monto de intercambio"
msgstr "Los costos de Swap y Bridge serán por lo menos {formattedFeePercentage}% del monto de intercambio"

# Receive amount labels
# Notifications / jobs aria labels
Expand Down
10 changes: 9 additions & 1 deletion apps/cowswap-frontend/src/locales/ru-RU.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2554,6 +2554,10 @@ msgstr "Обзор токенов"
msgid "Enter slippage percentage between {min}% and {max}%"
msgstr "Введите процент проскальзывания между {min}% и {max}%"

#: apps/cowswap-frontend/src/modules/trade/pure/ProtocolFeeRow/index.tsx
msgid "Protocol fee ({protocolFeeAsPercent}%)"
msgstr "Комиссия протокола ({protocolFeeAsPercent}%)"

Comment on lines +2557 to +2560
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Avoid duplicate msgid for Protocol fee ({protocolFeeAsPercent}%)

There is already an entry for this same msgid earlier in the file (around Line 2497) with an empty msgstr. Adding a second block with the same msgid can confuse gettext tooling (duplicate definitions) and makes it unclear which translation wins.

Suggestion: keep a single entry for

msgid "Protocol fee ({protocolFeeAsPercent}%)"
msgstr "Комиссия протокола ({protocolFeeAsPercent}%)"

and delete the other duplicated block so this msgid appears only once.

🤖 Prompt for AI Agents 
In apps/cowswap-frontend/src/locales/ru-RU.po around lines 2557-2560 (and the
duplicate around line ~2497), there are two msgid entries for "Protocol fee
({protocolFeeAsPercent}%)" which creates a duplicate; remove the
earlier/duplicate block (the one at ~line 2497) and keep a single entry with
msgid "Protocol fee ({protocolFeeAsPercent}%)" and msgstr "Комиссия протокола
({protocolFeeAsPercent}%)", ensuring only one definition exists and no empty
msgstr remains.

#: apps/cowswap-frontend/src/modules/orderProgressBar/pure/TransactionSubmittedContent/SurplusModal.tsx
msgid "Learn how"
msgstr "Узнайте как"
Expand Down Expand Up @@ -2748,6 +2752,10 @@ msgstr "Уведомления о сделках включены"
msgid "gas"
msgstr "газ"

#: apps/cowswap-frontend/src/common/pure/ReceiveAmountInfo/index.tsx
msgid "Protocol fee"
msgstr "Комиссия протокола"

#: apps/cowswap-frontend/src/modules/hooksStore/pure/HookListItem/index.tsx
msgid "details"
msgstr "подробнее"
Expand Down Expand Up @@ -3289,7 +3297,7 @@ msgstr "Утвердите токен, чтобы продолжить."

#: apps/cowswap-frontend/src/modules/trade/pure/ProtocolFeeRow/index.tsx
msgid "This {protocolFeeBps} BPS fee incentivizes solvers to find better prices for users. It is only applied if the trade is executed."
msgstr ""
msgstr "Комиссия в размере {protocolFeeBps} BPS стимулирует солверов находить лучшие цены для пользователей. Она взимается только при выполнении сделки."

#: apps/cowswap-frontend/src/modules/accountProxy/pure/AccountCard/DefaultAccountContent.tsx
msgid "Recoverable value"
Expand Down