New Crowdin updates #6593
New Crowdin updates #6593
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdded and updated localization entries in cowswap-frontend PO files: new ARIA labels "Trade alert settings" and "View jobs (opens in a new tab)" for en-US, es-ES, pt-BR, ru-RU; multiple Spanish UI strings translated; PO-Revision-Date values updated where present. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
apps/cowswap-frontend/src/locales/ru-RU.po (1)
6276-6281: New ARIA label translations are accurate; consider wording for "jobs"
- "Настройки уведомлений о сделках" is a good, clear label for “Trade alert settings”.
- "Просмотр заданий (откроется в новой вкладке)" preserves both the action and the “new tab” hint; however, for hiring-related copy, "Просмотр вакансий (откроется в новой вкладке)" would be more idiomatic Russian. If you ever revise the existing “View jobs” translation above, you may want to align both strings on “вакансий”.
apps/cowswap-frontend/src/locales/es-ES.po (2)
2738-2741: Consider aligning “trade alerts” terminology
"Alertas de trading activadas"reads well, but elsewhere ("Trade alerts"→"Alertas comerciales") uses different wording. For consistency, you might pick one (alertas comercialesvsalertas de trading) across these related strings.
6276-6282: New ARIA label translations look good; optional phrasing tweakBoth labels are clear and convey the new-tab behavior. If you want slightly more natural screen‑reader phrasing, you could use future tense, e.g.
"Ver trabajos (se abrirá en una pestaña nueva)", but the current text is perfectly serviceable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/cowswap-frontend/src/locales/es-ES.po(3 hunks)apps/cowswap-frontend/src/locales/pt-BR.po(2 hunks)apps/cowswap-frontend/src/locales/ru-RU.po(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-24T16:42:53.154Z
Learnt from: cowdan
Repo: cowprotocol/cowswap PR: 6009
File: apps/cowswap-frontend/src/modules/tradeWidgetAddons/containers/HighFeeWarning/HighFeeWarningTooltipContent.tsx:23-33
Timestamp: 2025-07-24T16:42:53.154Z
Learning: In apps/cowswap-frontend/src/modules/tradeWidgetAddons/containers/HighFeeWarning/HighFeeWarningTooltipContent.tsx, the use of toFixed(2) for percentage formatting in tooltip content is intentional and differs from the banner message formatting that uses toSignificant(2, undefined, Rounding.ROUND_DOWN). This formatting difference serves different UX purposes and should not be flagged as inconsistent.
Applied to files:
apps/cowswap-frontend/src/locales/ru-RU.poapps/cowswap-frontend/src/locales/es-ES.po
🔇 Additional comments (4)
apps/cowswap-frontend/src/locales/pt-BR.po (1)
11-11: LGTM - Revision date updated correctlyThe revision date has been properly updated to reflect the current translation sync.
apps/cowswap-frontend/src/locales/ru-RU.po (2)
11-11: Header revision date bump is finePO-Revision-Date update is consistent with a new Crowdin sync; no issues.
2738-2741: "Trade alerts enabled" translation looks correct"Уведомления о сделках включены" accurately conveys the original meaning and fits existing notification phrasing.
apps/cowswap-frontend/src/locales/es-ES.po (1)
11-11: Revision date bump is fine
PO-Revision-Dateis correctly updated and matches the PR timestamp; nothing else to adjust here.
| # Notifications / jobs aria labels | ||
| msgid "Trade alert settings" | ||
| msgstr "" | ||
|
|
||
| msgid "View jobs (opens in a new tab)" | ||
| msgstr "" |
There was a problem hiding this comment.
Missing Portuguese translations for ARIA labels
The two new ARIA label entries have empty translations (msgstr ""), which means Portuguese-speaking users will see English text or potentially no text for these accessibility labels:
- "Trade alert settings"
- "View jobs (opens in a new tab)"
Since these are ARIA labels, they're important for screen reader users. Consider verifying that these translations are completed in Crowdin before merging, or ensure there's a follow-up to add the Portuguese translations.
🤖 Prompt for AI Agents
In apps/cowswap-frontend/src/locales/pt-BR.po around lines 6271 to 6276, two
ARIA label entries currently have empty translations ("msgstr """): "Trade alert
settings" and "View jobs (opens in a new tab)". Add accurate Portuguese
translations for both msgstr values (e.g., "Configurações de alertas de
negociação" and "Ver trabalhos (abre em uma nova aba)" or preferred translations
from Crowdin), save the file, and/or push the changes to Crowdin so the
translated strings are available for screen readers before merging.
|
Those changes are already in develop |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.