Skip to content

Conversation

@elena-zh
Copy link
Contributor

@elena-zh elena-zh commented Dec 9, 2025

Adds a space to these buttons in the 'Build your own hook' hook:
image
image

To test:

  1. Open Swap page
  2. OPen settings on the page and enable Hooks store there
  3. Navigate to the hooks store once the setting is enabled
  4. Press on the 'Add Pre-hook Action'
  5. Press on 'Open' on the 'Build your own hook' hook
  6. Check the button name
  7. Repeat same steps for 'Add Post-hook Action'

AR: 'Add hook' button should contain space between words.


Additionally, attempts to fix this issue:
image


Summary by CodeRabbit

  • Bug Fixes

    • Fixed button text formatting to include proper spacing between the action label and hook type indicator for improved readability.
  • Documentation

    • Adjusted a translation string to add missing spacing around a placeholder, ensuring correct display in the UI.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
cowfi Ready Ready Preview Dec 9, 2025 0:25am
explorer-dev Ready Ready Preview Dec 9, 2025 0:25am
swap-dev Ready Ready Preview Dec 9, 2025 0:25am
widget-configurator Ready Ready Preview Dec 9, 2025 0:25am
2 Skipped Deployments
Project Deployment Preview Updated (UTC)
cosmos Ignored Ignored Dec 9, 2025 0:25am
sdk-tools Ignored Ignored Preview Dec 9, 2025 0:25am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

Warning

Rate limit exceeded

@elena-zh has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 20 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between cdc7535 and 26b13e5.

📒 Files selected for processing (5)
  • apps/cowswap-frontend/src/locales/en-US.po (2 hunks)
  • apps/cowswap-frontend/src/locales/es-ES.po (2 hunks)
  • apps/cowswap-frontend/src/locales/pt-BR.po (2 hunks)
  • apps/cowswap-frontend/src/locales/ru-RU.po (2 hunks)
  • apps/cowswap-frontend/src/modules/limitOrders/pure/RateImpactWarning/index.tsx (1 hunks)

Walkthrough

Two small whitespace fixes: one in the BuildHookApp button label to add a space between "Add" and the dynamic Pre/Post hook label, and one in the English locale string to add a space before a placeholder in a rate-impact warning message.

Changes

Cohort / File(s) Summary
Button text formatting
apps/cowswap-frontend/src/modules/hooksStore/dapps/BuildHookApp/index.tsx
Inserted an explicit space between "Add" and the dynamic Pre/Post hook label in ButtonPrimary text (e.g., "Add Pre-hook" instead of "AddPre-hook").
Localization whitespace
apps/cowswap-frontend/src/locales/en-US.po
Added a space before the <0/> placeholder in the RateImpactWarning translation string to match updated source spacing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review the button label change in BuildHookApp/index.tsx to ensure spacing works with localization/RTL if applicable.
  • Verify the translation string update in en-US.po matches the component's new msgid and doesn't break pluralization/placeholders.

Suggested reviewers

  • alfetopito
  • shoom3301

Poem

A tiny hop, a tidy space,
Words align in perfect place,
Add Pre-hook, Add Post-hook bright,
The UI breathes, the label’s right,
~CodeRabbit 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check ✅ Passed The PR description includes visual evidence, clear testing steps, and expected acceptance criteria aligned with the changes made.
Title check ✅ Passed The title clearly and accurately describes the main changes: adding space to the add hook button and to the limit order's warning message.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel vercel bot temporarily deployed to Preview – explorer-dev December 9, 2025 11:51 Inactive
@vercel vercel bot temporarily deployed to Preview – sdk-tools December 9, 2025 11:51 Inactive
@vercel vercel bot temporarily deployed to Preview – widget-configurator December 9, 2025 11:51 Inactive
@elena-zh elena-zh self-assigned this Dec 9, 2025
@elena-zh elena-zh marked this pull request as ready for review December 9, 2025 11:59
@elena-zh elena-zh requested a review from a team December 9, 2025 11:59
@elena-zh elena-zh requested a review from a team December 9, 2025 12:02
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@elena-zh elena-zh merged commit b0a3c3e into develop Dec 9, 2025
15 checks passed
@elena-zh elena-zh deleted the add-space-to-button branch December 9, 2025 12:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants