[DRAFT] refactor: enhance useGetReceipt hook to support multiple providers an…#7121
Draft
fairlighteth wants to merge 2 commits into
Draft
[DRAFT] refactor: enhance useGetReceipt hook to support multiple providers an…#7121fairlighteth wants to merge 2 commits into
fairlighteth wants to merge 2 commits into
Conversation
…d improve error handling
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6157
Improve ETH-flow transaction finalization when the wallet provider fails to return a tx receipt. useGetReceipt now falls back to the app public RPC provider before giving up, which helps prevent ETH-flow creation orders from getting stuck in a local creating state when the tx was already mined or refunded on-chain.
This PR also adds targeted tests for:
To Test
onchainTransactions/updaters/FinalizeTxUpdater/services/checkOnChainTransaction.test.ts passes
FinalizeTxUpdater/services/checkOnChainTransaction.test.ts passes
Background
The investigation suggests the problematic case is not the normal backend-driven order status flow after an order already exists in the API. The risky path is earlier: ETH-flow creation can fail before the order
is ever available in the backend, and in that case the frontend depends on tx receipt polling to invalidate the local order.
Before this change, that receipt polling depended only on the wallet provider. If the wallet stopped returning receipts, the local ETH-flow order could remain stuck even though the chain already had the final result. This PR narrows that gap by falling back to the app RPC provider for receipt reads.