chore: remove staging deployment v1 step#7878
Conversation
Already moved staging 100% to the new build flow. Removing it from the deployment v1 workflow.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
WalkthroughThe deployment workflow now runs only through manual dispatch, removes the Vercel pre-production job, and updates failure notifications to depend solely on the production deployment. ChangesDeployment workflow
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8).github/workflows/deployment.ymlTraceback (most recent call last): Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/deployment.yml (1)
20-20: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove redundant job-level condition.
Since the automated push triggers were removed and
workflow_dispatchis now the only way to trigger this workflow, this condition is always true and can be safely removed.♻️ Proposed refactor
name: Vercel prod - if: github.event_name == 'workflow_dispatch' uses: ./.github/workflows/vercel.yml🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/deployment.yml at line 20, Remove the redundant job-level if condition checking github.event_name == 'workflow_dispatch' from the deployment workflow, leaving the job to run directly whenever the workflow is dispatched.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deployment.yml:
- Line 35: Update the failure notification condition in the deployment workflow
to remove the github.ref restriction, while preserving the failure check so
Slack alerts trigger for failed manual deployments from branches or release
tags.
---
Nitpick comments:
In @.github/workflows/deployment.yml:
- Line 20: Remove the redundant job-level if condition checking
github.event_name == 'workflow_dispatch' from the deployment workflow, leaving
the job to run directly whenever the workflow is dispatched.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: bec05594-e492-486a-ad8c-c16a33e5e573
📒 Files selected for processing (1)
.github/workflows/deployment.yml
|
Closed in favor of #7886 |
Summary
Already moved staging 100% to the new build flow.
Removing it from the deployment v1 workflow.
To Test
Only once deployed.
The test:
Summary by CodeRabbit