Skip to content

chore: remove staging deployment v1 step#7878

Closed
azebuado wants to merge 1 commit into
developfrom
chore/disable-staging-v1
Closed

chore: remove staging deployment v1 step#7878
azebuado wants to merge 1 commit into
developfrom
chore/disable-staging-v1

Conversation

@azebuado

@azebuado azebuado commented Jul 21, 2026

Copy link
Copy Markdown

Summary

Already moved staging 100% to the new build flow.
Removing it from the deployment v1 workflow.

To Test

Only once deployed.
The test:

  • No more staging builds triggered when a new tag is published
  • Workflow no longer triggers on pushes to main/develop

Summary by CodeRabbit

  • Chores
    • Deployment workflows can now be started manually rather than automatically from branch or tag changes.
    • Removed automatic pre-production deployments.
    • Failure notifications now track production deployment results only.

Already moved staging 100% to the new build flow.
Removing it from the deployment v1 workflow.
@azebuado azebuado self-assigned this Jul 21, 2026
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cowfi Ready Ready Preview Jul 21, 2026 10:20am
explorer-dev Ready Ready Preview Jul 21, 2026 10:20am
sdk-tools Ready Ready Preview Jul 21, 2026 10:20am
storybook Ready Ready Preview Jul 21, 2026 10:20am
swap-dev Ready Ready Preview Jul 21, 2026 10:20am
widget-configurator Ready Ready Preview Jul 21, 2026 10:20am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
cosmos Ignored Ignored Jul 21, 2026 10:20am

Request Review

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The deployment workflow now runs only through manual dispatch, removes the Vercel pre-production job, and updates failure notifications to depend solely on the production deployment.

Changes

Deployment workflow

Layer / File(s) Summary
Manual production deployment
.github/workflows/deployment.yml
The push-based trigger and tag-driven pre-production deployment were removed; failure notification now depends only on vercel-prod.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: alfetopito

Poem

I’m a rabbit who hops through the flow,
Manual launches now set the show.
Pre-prod has vanished from the trail,
Prod alone reports success or fail.
Carrots deploy with a wiggle and cheer!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the removal of the staging deployment step from the deployment workflow.
Description check ✅ Passed The description includes a summary and test notes, with only the optional background section missing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/disable-staging-v1

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
.github/workflows/deployment.yml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@azebuado

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Jul 21, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/deployment.yml (1)

20-20: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Remove redundant job-level condition.

Since the automated push triggers were removed and workflow_dispatch is now the only way to trigger this workflow, this condition is always true and can be safely removed.

♻️ Proposed refactor
     name: Vercel prod
-    if: github.event_name == 'workflow_dispatch'
     uses: ./.github/workflows/vercel.yml
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/deployment.yml at line 20, Remove the redundant job-level
if condition checking github.event_name == 'workflow_dispatch' from the
deployment workflow, leaving the job to run directly whenever the workflow is
dispatched.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/deployment.yml:
- Line 35: Update the failure notification condition in the deployment workflow
to remove the github.ref restriction, while preserving the failure check so
Slack alerts trigger for failed manual deployments from branches or release
tags.

---

Nitpick comments:
In @.github/workflows/deployment.yml:
- Line 20: Remove the redundant job-level if condition checking
github.event_name == 'workflow_dispatch' from the deployment workflow, leaving
the job to run directly whenever the workflow is dispatched.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bec05594-e492-486a-ad8c-c16a33e5e573

📥 Commits

Reviewing files that changed from the base of the PR and between 284fdb5 and e94f610.

📒 Files selected for processing (1)
  • .github/workflows/deployment.yml

Comment thread .github/workflows/deployment.yml
@azebuado
azebuado requested review from a team, Danziger and limitofzero July 21, 2026 10:28
@azebuado

Copy link
Copy Markdown
Author

Closed in favor of #7886

@azebuado azebuado closed this Jul 22, 2026
@azebuado
azebuado deleted the chore/disable-staging-v1 branch July 22, 2026 15:52
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants