-
Notifications
You must be signed in to change notification settings - Fork 24
Update documentation reference to bonding pools #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpdated documentation for bonding pools: clarified that the reduced-bonding-pool size progression occurs over the following year, adjusted wording from "the solver" to "a solver with a reduced bonding pool," and expanded the Vouching contracts list with Avalanche, Polygon, Lens, BNB, and Linea (Lens URL formatting corrected). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/cow-protocol/reference/core/auctions/bonding_pools.md(2 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/cow-protocol/reference/core/auctions/bonding_pools.md
[grammar] ~13-~13: Use a hyphen to join words.
Context: ...lver needs to deposit $50,000 in (yield bearing) stable coins or ETH, and 500,00...
(QB_NEW_EN_HYPHEN)
[grammar] ~13-~13: Use a hyphen to join words.
Context: ... year all the way to $100,000 in (yield bearing) stable coins or ETH, and 1,000,...
(QB_NEW_EN_HYPHEN)
🔇 Additional comments (2)
docs/cow-protocol/reference/core/auctions/bonding_pools.md (2)
15-15: Grammar improvement is well-applied.The change from "the solver with a reduced bonding pool" to "a solver with a reduced bonding pool" reads more naturally and is grammatically sound.
13-15: Documentation updates enhance clarity and network coverage.The narrative clarification specifying that reduced bonding pools are built "over the course of the following year" provides better expectation setting. The expansion to five additional networks (Avalanche, Polygon, Lens, BNB, Linea) appropriately reflects CoW Protocol's expanded deployment footprint.
Also applies to: 25-29
fhenneke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The AI comments make sense to me, so you can include their suggestions.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
| Assuming that the core team approves the creation of a reduced bonding pool, the first step for setting up a reduced bonding pool is to deploy a Gnosis safe on Mainnet that has only one signer (the CoW DAO Solver Payouts safe, that is, eth:0xA03be496e67Ec29bC62F01a428683D7F9c204930). After this is done and has been confirmed by the CoW DAO team, the solver needs to deposit \$50,000 in (yield-bearing) stable coins or ETH, and 500,000 COW tokens to the newly created safe, and gradually build the pool's size over the course of the following year all the way to \$100,000 in (yield-bearing) stable coins or ETH, and 1,000,000 COW tokens. | ||
|
|
||
| We stress that the reduced bonding pool setup is just an arrangement within the CoW DAO bonding pool; meaning that the solver with a reduced bonding pool is still formally vouched under the CoW DAO bonding pool. | ||
| We stress that the reduced bonding pool setup is just an arrangement within the CoW DAO bonding pool; meaning that a solver with a reduced bonding pool is still formally vouched under the CoW DAO bonding pool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pool is still formally vouched --> pool is still formally vouched for
pretf00d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small correction
Description
This PR updates the documentation reference to bonding pools to include all networks CoW Protocol is currently active on.
Changes
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.